GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
It looks strange having some of the values in three k/v pair
blocks and then having the remainder one per line.
reformating ESCAPED_CHARS hash
Thank you for the pull request, but we prefer to not accept this kind of cosmetic changes.
@rafaelfranca Sorry for wasting your effort needing to review it. I added a note to that effect to the contributor guide via docrails to that effect.
I'm sorry. There is a reason to not accept this kind of changes, if we start to accept things like: "Changing the hash syntax to 1.9", "Replace unless with if", "Change the indentation of code" we will start to receive a lot of pull request doing these changes.
This will lead a lot of effort of the core team to review and merge these pull request, without any real gain to the framework.
I really appreciate your effort to make this pull request and I really want to see more contributions from you.
Thank you for the guides notes.