if format is unknown NullMimeTypeObject is returned #8084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc / @guilleiguaran |
| request.expects(:parameters).at_least_once.returns({ :format => :hello }) | ||
| assert_equal request.format.html?, false | ||
| assert_equal request.format.xml?, false | ||
| assert_equal request.format.json?, false |
There was a problem hiding this comment.
Wrong indent. Can use new hash style, and can test using assert !request.format.html?
|
@acapilleri a changelog entry is also welcome :). Thanks |
If a unknown format is passed in a request, the methods html?, xml?, json? ...etc Nil Exception. This patch add a class NullMimeTypeObject, that is returned when request.format is unknown and it responds false to the methods that ends with '?'. It refers to rails#7837, not fixes because it's not considered a improvement not a bug.
rafaelfranca
added a commit
that referenced
this pull request
Oct 31, 2012
if format is unknown NullMimeTypeObject is returned
|
Hey mate, this has broken the build, some Action Pack failures, can you please take a look? Thanks! |
|
ok... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a unknown format is passed in a request, the methods html?, xml?, json? ...etc
Nil Exception.
This patch add a class NullMimeTypeObject, that is returned when request.format is unknown
and it responds false to the methods that ends with '?'.
It refers to #7837, not fixes because it's not considered a improvement not a bug.