-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #8086 (BestStandardsSupport rewrites app X-UA-Compatible header) #8093
Fix #8086 (BestStandardsSupport rewrites app X-UA-Compatible header) #8093
Conversation
Will probably need a 3.2 backport |
Looks good. It needs a changelog entry, thanks! |
…der, now appends). Now `BestStandardsSupport` middleware appends it's `X-UA-Compatible` value to app's value. Also test for `BestStandardsSupport` middleware added.
@carlosantoniodasilva thanks, done. Do it need a backport? |
|
||
expects = "requiresActiveX=true,IE=Edge,chrome=1" | ||
assert_equal expects, headers["X-UA-Compatible"] | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you give it false
, but has X-UA-Compatible
set in the app? Will it override the users' value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, don't worry, the middleware is not added if the config is false
.
Fix #8086 (BestStandardsSupport rewrites app X-UA-Compatible header)
@nikitug I think it can be backported without problem yeah, but we will need to wait until 3.2.9 is released. Thanks! |
Fix #8086 (BestStandardsSupport rewrites app X-UA-Compatible header) Conflicts: actionpack/CHANGELOG.md
Backported in 90a5ec7, thanks. |
Now
BestStandardsSupport
middleware appends it'sX-UA-Compatible
value to app's value.Also test for
BestStandardsSupport
middleware added.