Fix #8086 (BestStandardsSupport rewrites app X-UA-Compatible header) #8093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will probably need a 3.2 backport |
|
Looks good. It needs a changelog entry, thanks! |
…der, now appends). Now `BestStandardsSupport` middleware appends it's `X-UA-Compatible` value to app's value. Also test for `BestStandardsSupport` middleware added.
|
@carlosantoniodasilva thanks, done. Do it need a backport? |
|
|
||
| expects = "requiresActiveX=true,IE=Edge,chrome=1" | ||
| assert_equal expects, headers["X-UA-Compatible"] | ||
| end |
There was a problem hiding this comment.
What happens if you give it false, but has X-UA-Compatible set in the app? Will it override the users' value?
There was a problem hiding this comment.
Anyway, don't worry, the middleware is not added if the config is false.
carlosantoniodasilva
added a commit
that referenced
this pull request
Nov 1, 2012
Fix #8086 (BestStandardsSupport rewrites app X-UA-Compatible header)
|
@nikitug I think it can be backported without problem yeah, but we will need to wait until 3.2.9 is released. Thanks! |
carlosantoniodasilva
added a commit
that referenced
this pull request
Nov 8, 2012
Fix #8086 (BestStandardsSupport rewrites app X-UA-Compatible header) Conflicts: actionpack/CHANGELOG.md
|
Backported in 90a5ec7, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
BestStandardsSupportmiddleware appends it'sX-UA-Compatiblevalue to app's value.Also test for
BestStandardsSupportmiddleware added.