Fix info page style #8737
Merged
Fix info page style #8737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I think you need to squash commits. |
| @@ -179,6 +179,7 @@ | |||
| else | |||
| { xhr = new ActiveXObject("Microsoft.XMLHTTP"); } | |||
| xhr.open("GET","rails/info/properties",false); | |||
There was a problem hiding this comment.
Can you add some whitespaces to those parameters?
There was a problem hiding this comment.
OK. I added whitespace in 6bd3d0f00e99f8a706fcda3d258f2c9524792e55
|
Thanks @goshakkk . |
|
@guilleiguaran can you have a look? |
|
I rebased this commit to make it automatically mergeable. |
carlosantoniodasilva
added a commit
that referenced
this pull request
Jan 5, 2013
Fix info page style [ci skip]
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I click link "About your application's environment" at welcome page, the page style (such as font, background color etc) are broken. (see the following images.)
This cause is that the partial page loaded by xhr contains their own css.
So I stop containing css in loaded page.
Before click:
After click:
