Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer do-end for multiline block #8774

Merged
merged 1 commit into from
Jan 6, 2013
Merged

Prefer do-end for multiline block #8774

merged 1 commit into from
Jan 6, 2013

Conversation

goshacmd
Copy link
Contributor

@goshacmd goshacmd commented Jan 5, 2013

No description provided.

carlosantoniodasilva added a commit that referenced this pull request Jan 6, 2013
@carlosantoniodasilva
Merge pull request #8774 from goshakkk/multiline-block-do-end
bdffd1e 
Prefer do-end for multiline block [ci skip]
@carlosantoniodasilva carlosantoniodasilva merged commit bdffd1e into rails:master Jan 6, 2013
@goshacmd goshacmd deleted the multiline-block-do-end branch January 6, 2013 00:27
@steveklabnik
Copy link
Member

I don't care that this got merged, but wouldn't this fall under 'cosmetic' normally?

@carlosantoniodasilva
Copy link
Member

@steveklabnik definitely, I just merged because 2 of the 3 changes were in guides, and I prefer do..end for multiline blocks, so I thought it'd be better to have the examples like that. If all changes were in code, I'd go for cosmetic.

@steveklabnik
Copy link
Member

Roger! Just putting that away in the brain for future PRs. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goshacmd @steveklabnik @carlosantoniodasilva