Prefer do-end for multiline block #8774

Merged
merged 1 commit into from Jan 6, 2013

Projects

None yet

3 participants

@goshakkk
Contributor
goshakkk commented Jan 5, 2013

No description provided.

@carlosantoniodasilva carlosantoniodasilva merged commit bdffd1e into rails:master Jan 6, 2013
@goshakkk goshakkk deleted the goshakkk:multiline-block-do-end branch Jan 6, 2013
Member

I don't care that this got merged, but wouldn't this fall under 'cosmetic' normally?

@steveklabnik definitely, I just merged because 2 of the 3 changes were in guides, and I prefer do..end for multiline blocks, so I thought it'd be better to have the examples like that. If all changes were in code, I'd go for cosmetic.

Member

Roger! Just putting that away in the brain for future PRs. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment