Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review, please: Capture block so content won't leak. #8936

Closed
wants to merge 1 commit into from
Closed

Review, please: Capture block so content won't leak. #8936

wants to merge 1 commit into from

Commits on Jan 14, 2013

  1. Review, please: Capture block so content won't leak. 

    The [following pull request](#8916) fixed
the block being passed to the appropriate helper method. However, the content
being passed into the block is generating repeated markup on the page due to
some weird ERb evaluation.

This commit tries to capture the block's generated output so the page isn't
flooded with markup, but I'm not able to make the tests pass due to a missing
output buffer. Please help me review this behavior.
    @josemotanet
    josemotanet committed Jan 14, 2013
    Configuration menu
    Copy the full SHA
    e91e55a View commit details
    Browse the repository at this point in the history