Collection radio buttons and collection check boxes through FormBuilder render the provided block #8916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er render the provided block. In the case of having a form_for method being called, the block for each collection would not be passed and thus the result expected was always the same. This patch passes the block to the original method like it would be assumed.
|
This fixes issue #8897. /cc @rafaelfranca |
rafaelfranca
added a commit
that referenced
this pull request
Jan 14, 2013
Collection radio buttons and collection check boxes through FormBuilder render the provided block. Closes #8897
|
Thank you so much, and welcome to Rails Contributors |
sgerrand
pushed a commit
to sgerrand/rails
that referenced
this pull request
Nov 2, 2013
The [following pull request](rails#8916) fixed the block being passed to the appropriate helper method. However, the content being passed into the block is generating repeated markup on the page due to some weird ERb evaluation. This commit tries to capture the block's generated output so the page isn't flooded with markup. [Rafael França + José Mota] Closes rails#8936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of having a
form_formethod being called, the block for eachcollection would not be passed and thus the result expected was always the same.
This patch passes the block to the original method like it would be assumed.