Rework headers functional tests #9716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlosantoniodasilva @pixeltrix let me know what you think. |
| @@ -626,6 +630,24 @@ def test_params_passing_doesnt_modify_in_place | |||
| assert_equal 2004, page[:year] | |||
| end | |||
|
|
|||
| test "set additional HTTP headers" do | |||
| @request.env['Referer'] = "http://www.google.com" | |||
| @request.env['Content-Type'] = "application/rss+xml" | |||
There was a problem hiding this comment.
Shouldn't these be @request.headers ?
|
@pixeltrix the fact that I used both notations is clearly a sign that it is confusing 😄 it is the other way around though. Using |
|
@pixeltrix I updated the examples to be more useful. The access is still through |
The env hash passed to `Http::Headers#new` must be in env format. Also be aware that the passed hash is modified directly. docs and test-cases for setting headers/env in functional tests. Follow up to rails#9700.
pixeltrix
added a commit
that referenced
this pull request
Mar 15, 2013
Rework headers functional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. headers in functional tests
#9700 already added support for functional tests as well. I just added test-cases to lock the behaviour and updated the documentation accordingly.
2. document functional tests
I added documentation for the request simulation methods in functional tests.