Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Change Standard error when is required bcrypt-ruby and fails #9863

Merged
merged 1 commit into from Mar 22, 2013

Conversation

Projects
None yet
3 participants
Contributor

robertomiranda commented Mar 22, 2013

No description provided.

@guilleiguaran guilleiguaran added a commit that referenced this pull request Mar 22, 2013

@guilleiguaran guilleiguaran Merge pull request #9863 from robertomiranda/require-bcrypt-ruby
Change Standard error when is required bcrypt-ruby and fails
0d3cb00

@guilleiguaran guilleiguaran merged commit 0d3cb00 into rails:master Mar 22, 2013

@robertomiranda robertomiranda deleted the robertomiranda:require-bcrypt-ruby branch Mar 22, 2013

Owner

jeremy commented on 7e07b7b Sep 30, 2013

This masks the original exception backtrace and outputs the true error on stderr instead of in the exception message. Instead, this should rescue the gem activation error and raise a BcryptMissing error with this message.

Better yeah, get rid of the runtime gem activation entirely. If it's the app's responsibility to provide bcrypt, then simple require bcrypt here.

Owner

jeremy replied Sep 30, 2013

(Looks like the re-raise was fixed in a03ab8c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment