Refactoring validate_missing_parameters to validate_required_parameters. #9880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
added a commit
that referenced
this pull request
Mar 23, 2013
Refactoring validate_missing_parameters to validate_required_parameters.
|
Thank you ❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside of assign_attributes, there is a method which checks to make sure that particular parameters exist. The previous method name was
validate_missing_parameters!and sounds like some parameters should be missing, when in fact it's meant to check to make sure none of the parameters passed in as arguments are missing.Because of this, I think that
validate_required_parameters!is a more apt name. I also removed a space in the middle of an empty hash.