Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows compatibility #16

Closed
luislavena opened this issue Jan 2, 2010 · 1 comment
Closed

Improve Windows compatibility #16

luislavena opened this issue Jan 2, 2010 · 1 comment

Comments

@luislavena
Copy link
Contributor

As Thor will be an important part of Rails 3, compatibility with Windows should be taken in consideration.

In the following gist you will find diff/patches to be applied over master that fix file operation and also increase the compatibility with Ruby 1.9.

http://gist.github.com/267357

On a side note, I noticed a lot of specs depends on successfully execution of previous one, making impossible ensure specs are doing what it suppose to (try executing with reverse options).

Cheers!

@josevalim
Copy link
Contributor

Thanks, merged. reverse order works with 1.8.7, not in 1.9.1. I really think this is a rr issue (their issues tracker says it haves problem with stubs on 1.8.7). I tried to fix, but I think I will simply migrate to another mocking solution.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants