-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esModule file-loader compat #2613
Comments
Are you using the |
Not that I know of and I don't see it in my yarn.lock file.
|
I met a similar issue with environment.loaders.get('file').use.find(item => item.loader === 'file-loader').options.esModule = false |
Same here, no special loaders, but |
I'm so glad I found this! Is this something that should be fixed in |
Hey! I saw this and #2668. I think a more specific solution would be not to set WDYT? |
I recently upgraded an app from webpacker 4 -> 5. When I did that my "fontawesome" icons went away. I found the font was not loading despite being in the
static_assets_extensions
. When I looked at the compiled CSS it looked like:I did a search and found a related issue on stack overflow that indicates adding
esModule: false
to the fileloader options:https://stackoverflow.com/questions/57671995/webpack-4-gives-background-urlobject-module-as-bg-image
I looked at the file-loader package and it appears in v5 they made a breaking change documented as:
Since the file-loader config is controlled by webpacker making that config change would not be easy to do. Instead I downgraded to version 4.3 of
file-loader
and things are now working fine.Seems either webpacker needs to be updated to use this
esModule: false
option or some other change needs to be made so it is compat with the new wayfile-loader
is doing things.The text was updated successfully, but these errors were encountered: