Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply different background to context lines #2

Closed
wants to merge 1 commit into from
Closed

Apply different background to context lines #2

wants to merge 1 commit into from

Conversation

jswanner
Copy link
Member

screen shot 2015-02-28 at 4 25 54 pm

@jswanner
Copy link
Member Author

I'm not sure if this is helpful or just noise.

@nbibler
Copy link
Member

nbibler commented Mar 1, 2015

Seems good... GitHub does it because it shows the region of the diff that was previously collapsed which the user has expanded. In this case, since that functionality isn't there, it doesn't map well.

However, I think it's subtle enough that it's fine presuming that the processing overhead isn't significant on the client.

@jswanner jswanner closed this Mar 27, 2021
@jswanner jswanner deleted the branch master March 27, 2021 02:21
@nbibler nbibler deleted the highlight-context branch April 8, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jswanner @nbibler