[APP-925]: Backend Driven Cards #5198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add card and cardCollection to arc * rm logs
* start progress on remote card * update remote card
* added card carousel to wallet and discover screen * update card and package
walmat
commented
Nov 27, 2023
src/components/asset-list/RecyclerAssetList2/core/RowRenderer.tsx
Outdated
Show resolved
Hide resolved
…ns size based on card length
walmat
requested review from
benisgold,
skylarbarrera and
jinchung
as code owners
|
Noticed on Android that the swipe on CardCarousel sometimes gets swallowed by the SwipeNavigator. Does anyone have any tips for fixing this? screen-20231130-095839.mp4 |
benisgold
reviewed
Dec 18, 2023
walmat
commented
Jan 17, 2024
| walletAddress: accountAddress, | ||
| }); | ||
|
|
||
| const cards = useMemo(() => getCardsForPlacement(name as string), [ |
There was a problem hiding this comment.
Question about name here. It looks like the route names might be different cross-platform; can we standardize that to points?
There was a problem hiding this comment.
Happy to chat about this. Original spec it made sense to group them based on the route. Open to suggestions on what you think the other locations should be called/named.
…ary button has action
skylarbarrera
approved these changes
Jan 18, 2024
| @@ -74,7 +74,7 @@ global.storage = storage; | |||
|
|
|||
| // shimming for reanimated need to happen before importing globalVariables.js | |||
| // eslint-disable-next-line import/no-commonjs | |||
| for (let variable of Object.entries(require('./globalVariables').default)) { | |||
| for (const variable of Object.entries(require('./globalVariables').default)) { | |||
There was a problem hiding this comment.
curious what was happening here
There was a problem hiding this comment.
i think on save it changed tbh
| /> | ||
| <PortalConsumer /> | ||
| </InitialRouteContext.Provider> | ||
| <RemoteCardProvider> |
There was a problem hiding this comment.
im hesitant if we need this in context vs just using the query directly but fine more of a q than a blocker
* fix weekly earnings total * leaderboard ranking diff * Update src/screens/points/content/PointsContent.tsx Co-authored-by: Matthew Wall <matthew.wallt@gmail.com> --------- Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>
walmat
added a commit
that referenced
this pull request
Jan 26, 2024
* [APP-1051]: (feat): add backups global config (#5306) * (feat): add backups global config * stash * add migration for setting initial backup method * add method to migrations array * revert pbx change * change backup status value * chore: hide testnet settings (#5308) * remote testnet settings * trying this * switch to breadcrumbs (#5309) * switch to breadcrumbs * change to debug calls * . (#5311) * bump version to v1.9.14 (#5312) * [APP-1052]: Add icon to Settings depending on `preferredBackupMethod` and `backupStatus` (#5313) * [APP-1052]: (feat): adjust settings page row * fix migration and hook for useWallets * simplify an if statement * chore: fix CI (#5307) * disable deeplinks jest tests * try this * disable * oop * anotha 1 * oop * swap changes * e2e for swap flow changes * testing * yes * revert file names * yup * audit: follow-redirects (#5323) * audit mmkv (#5325) * wallets and backups screen progress (#5315) * wallets and backups screen progress * manual backups progress * progress * feat(backups): more work on wallets and backups * revert pbx * rev init wallet change * final touches on wallets and backup view * f (#5327) * bump react-native-linear-gradient (#5328) * CHANGE: upgrade camera package to react-native-vision-camera FIX: [APP-171], [APP-776] (#5178) * init * init * more * GRR!!! BARK BARK * fixes * revert * fix * changes * changes * hoist * hook * comment * fix * i actually did it * cleanup 1 * get android build working * remove old package * move back to hook * . * . * . * build * build fix * provisioning profiles * bump ios version * . * . * oops * language change * final fixes * Update project.pbxproj --------- Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> Co-authored-by: skylarbarrera <skylar.barrera@gmail.com> * [APP-925]: Backend Driven Cards (#5198) * add experimental flag for remote cards (#5196) * [APP-929]: Add `RemoteCardProvider` and react-query calls (#5197) * add card and cardCollection to arc * rm logs * [APP-930]: Add `<RemoteCard />` component (#5203) * start progress on remote card * update remote card * [APP-932]: Add `<RemoteCardCarousel />` component (#5205) * added card carousel to wallet and discover screen * update card and package * tweaks to make carousel fit in * update styles * idkwtfiad * disable scroll when only one card is present and adjust view dimensions size based on card length * . * fix layout issues * remove unused debuglayout * fix card and re-enable check to not show cards again * Apply suggestions from code review * tweak discover page * add some testing edge cases * add remote config stuff * fix graphql schema * code review changes * change to new remote config hook * fix remote config * new design * start with view weekly earnings flow * progress on points breakdown from last week * Delete ios/.xcode.env.local * Update src/components/asset-list/RecyclerAssetList2/core/ViewDimensions.tsx * Update src/components/asset-list/RecyclerAssetList2/core/getLayoutProvider.tsx * Apply suggestions from code review * chore: rm snap carousel * Update shim.js * finish earnings screen * finish spec * adjust gutter size depending on how many cards are in the carousel * clean unused import * fix font weight on android and conditionally wrap remote card if primary button has action * fix recycler list view blank space for watched wallets * adjust card to prev card on dismissal * fix text formatting * fix: lint * change gutter size * fix text truncation * fix ios touch event overlap * fix: disable hiding cards in dev * Update src/components/cards/remote-cards/RemoteCardProvider.tsx * weekly earnings fix and leaderboard diff (#5330) * fix weekly earnings total * leaderboard ranking diff * Update src/screens/points/content/PointsContent.tsx Co-authored-by: Matthew Wall <matthew.wallt@gmail.com> --------- Co-authored-by: Matthew Wall <matthew.wallt@gmail.com> * filter & reduce --------- Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me> Co-authored-by: skylarbarrera <skylar.barrera@gmail.com> * bump: fastlane (#5331) * Points: rank card fixes (#5332) * fixes * fix ens display * Points: notifications toggle (#5329) * cleanup unused stuff and progress on backups flow * rename points topic (#5334) * rename points topic * Update constants.ts --------- Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com> * backups: warning + new secret phrase styles (#5322) * save progress * cleanup and finish secret phrase / private key viewiing screens --------- Co-authored-by: Matthew Wall <matthew.wallt@gmail.com> * chore: cleanup WalletsAndBackup settings screen and replace lang with i18n * bump minSdkVersion (#5337) * android settings fixes * progress on cloud backup flow * cloud backup flow progress --------- Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com> Co-authored-by: brdy <41711440+BrodyHughes@users.noreply.github.com> Co-authored-by: Ibrahim Taveras <ibrahim@rainbow.me> Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-925, APP-1055
What changed (plus any additional context for devs)
Read sub-issues here: https://linear.app/rainbow/issue/APP-925/backend-driven-cards
Also adds in retroactive points earnings breakdown as defined here:
https://linear.app/rainbow/issue/APP-1055/reuse-retro-points-animation-for-weekly-drops
Screen recordings / screenshots
Screenshots
How-to instructions
https://www.notion.so/rainbowdotme/Remote-Cards-bc2b7f290d224f9cae1c8780e9d8b07f