Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backups: warning + new secret phrase styles #5322

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

skylarbarrera
Copy link
Contributor

Fixes APP-1062 APP-1063

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

Base automatically changed from @matthew/APP-1053 to @matthew/APP-1049 January 11, 2024 18:37
@walmat walmat marked this pull request as ready for review January 23, 2024 17:19
@walmat walmat merged commit c8cd9c3 into @matthew/APP-1049 Jan 23, 2024
2 of 3 checks passed
@walmat walmat deleted the @skylar/secret-warning branch January 23, 2024 17:19
walmat added a commit that referenced this pull request Jan 26, 2024
* [APP-1051]: (feat): add backups global config (#5306)

* (feat): add backups global config

* stash

* add migration for setting initial backup method

* add method to migrations array

* revert pbx change

* change backup status value

* chore: hide testnet settings (#5308)

* remote testnet settings

* trying this

* switch to breadcrumbs (#5309)

* switch to breadcrumbs

* change to debug calls

* . (#5311)

* bump version to v1.9.14 (#5312)

* [APP-1052]: Add icon to Settings depending on `preferredBackupMethod` and `backupStatus` (#5313)

* [APP-1052]: (feat): adjust settings page row

* fix migration and hook for useWallets

* simplify an if statement

* chore: fix CI (#5307)

* disable deeplinks jest tests

* try this

* disable

* oop

* anotha 1

* oop

* swap changes

* e2e for swap flow changes

* testing

* yes

* revert file names

* yup

* audit: follow-redirects (#5323)

* audit mmkv (#5325)

* wallets and backups screen progress (#5315)

* wallets and backups screen progress

* manual backups progress

* progress

* feat(backups): more work on wallets and backups

* revert pbx

* rev init wallet change

* final touches on wallets and backup view

* f (#5327)

* bump react-native-linear-gradient (#5328)

* CHANGE: upgrade camera package to react-native-vision-camera FIX: [APP-171], [APP-776] (#5178)

* init

* init

* more

* GRR!!! BARK BARK

* fixes

* revert

* fix

* changes

* changes

* hoist

* hook

* comment

* fix

* i actually did it

* cleanup 1

* get android build working

* remove old package

* move back to hook

* .

* .

* .

* build

* build fix

* provisioning profiles

* bump ios version

* .

* .

* oops

* language change

* final fixes

* Update project.pbxproj

---------

Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me>
Co-authored-by: skylarbarrera <skylar.barrera@gmail.com>

* [APP-925]: Backend Driven Cards (#5198)

* add experimental flag for remote cards (#5196)

* [APP-929]: Add `RemoteCardProvider` and react-query calls (#5197)

* add card and cardCollection to arc

* rm logs

* [APP-930]: Add `<RemoteCard />` component (#5203)

* start progress on remote card

* update remote card

* [APP-932]: Add `<RemoteCardCarousel />` component (#5205)

* added card carousel to wallet and discover screen

* update card and package

* tweaks to make carousel fit in

* update styles

* idkwtfiad

* disable scroll when only one card is present and adjust view dimensions size based on card length

* .

* fix layout issues

* remove unused debuglayout

* fix card and re-enable check to not show cards again

* Apply suggestions from code review

* tweak discover page

* add some testing edge cases

* add remote config stuff

* fix graphql schema

* code review changes

* change to new remote config hook

* fix remote config

* new design

* start with view weekly earnings flow

* progress on points breakdown from last week

* Delete ios/.xcode.env.local

* Update src/components/asset-list/RecyclerAssetList2/core/ViewDimensions.tsx

* Update src/components/asset-list/RecyclerAssetList2/core/getLayoutProvider.tsx

* Apply suggestions from code review

* chore: rm snap carousel

* Update shim.js

* finish earnings screen

* finish spec

* adjust gutter size depending on how many cards are in the carousel

* clean unused import

* fix font weight on android and conditionally wrap remote card if primary button has action

* fix recycler list view blank space for watched wallets

* adjust card to prev card on dismissal

* fix text formatting

* fix: lint

* change gutter size

* fix text truncation

* fix ios touch event overlap

* fix: disable hiding cards in dev

* Update src/components/cards/remote-cards/RemoteCardProvider.tsx

* weekly earnings fix and leaderboard diff (#5330)

* fix weekly earnings total

* leaderboard ranking diff

* Update src/screens/points/content/PointsContent.tsx

Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>

---------

Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>

* filter & reduce

---------

Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me>
Co-authored-by: skylarbarrera <skylar.barrera@gmail.com>

* bump: fastlane (#5331)

* Points: rank card fixes (#5332)

* fixes

* fix ens display

* Points: notifications toggle (#5329)

* cleanup unused stuff and progress on backups flow

* rename points topic (#5334)

* rename points topic

* Update constants.ts

---------

Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com>

* backups: warning + new secret phrase styles (#5322)

* save progress

* cleanup and finish secret phrase / private key viewiing screens

---------

Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>

* chore: cleanup WalletsAndBackup settings screen and replace lang with i18n

* bump minSdkVersion (#5337)

* android settings fixes

* progress on cloud backup flow

* cloud backup flow progress

---------

Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com>
Co-authored-by: brdy <41711440+BrodyHughes@users.noreply.github.com>
Co-authored-by: Ibrahim Taveras <ibrahim@rainbow.me>
Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me>
skylarbarrera added a commit that referenced this pull request Mar 27, 2024
* [APP-1051]: (feat): add backups global config (#5306)

* (feat): add backups global config

* stash

* add migration for setting initial backup method

* add method to migrations array

* revert pbx change

* change backup status value

* [APP-1052]: Add icon to Settings depending on `preferredBackupMethod` and `backupStatus` (#5313)

* [APP-1052]: (feat): adjust settings page row

* fix migration and hook for useWallets

* simplify an if statement

* wallets and backups screen progress (#5315)

* wallets and backups screen progress

* manual backups progress

* progress

* feat(backups): more work on wallets and backups

* revert pbx

* rev init wallet change

* final touches on wallets and backup view

* cleanup unused stuff and progress on backups flow

* backups: warning + new secret phrase styles (#5322)

* save progress

* cleanup and finish secret phrase / private key viewiing screens

---------

Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>

* chore: cleanup WalletsAndBackup settings screen and replace lang with i18n

* android settings fixes

* @matthew/app 1106 (#5359)

* progress on cloud backup flow

* cloud backup flow progress

* [APP-1105]: Progress on restore from cloud flow (#5358)

* progress on restore from cloud

* progress on choose backup flow

* f

* test signed commit

* backups v2 restore from icloud flow done

* progress on restore step

* restore from backup working

* fix UserData.json restoring from other backups

* some cloud backup type improvements

* fix menu item width bug

* bug fixes

* cleanup unused imports from manage cloud backups file

* typescript, lint and cleanup

* fix lint issues

* fix file name casing

* fix import secret phrase or private key image

* fix casing

* android style fixes

* wrap up work

* android stuff

* android bsstack fixes

* more touches

* fixes

* improve spacing on >1 line wallet rows

* fix lint

* @matthew/app 1135 (#5397)

* fix button legibility

* fix manual backup bug

* change log

* fix bug where create wallet sometimes uses the wrong wallet

* add ens avatars to wallets view

* cleanup size

* add more padding to image on settings page

* fix

* fix algo used to calculate account menu item height

* add change drivce accounts for android

* cleanup .android files

* cleanup .android files

* change dev settings sheet title on android

* fix create wallet modal on close opening the create profile sheet

* add menu item being the entire context menu boundary (#5405)

* few small changes

* @matthew/app 1157 (#5406)

* sort wallets

* fix numeric increment and sort wallets by type and backup status

* i18n stuff

* add icons

* ens fix + context menu button color change (#5414)

* skylar did all this (#5409)

* skylar did all this

* change backupProvider to be served from user data and not local wallet state

* fix stuff

* cleanup merge

* add explainer sheet from global backups

* rm console logs

* improve pin screen on android

* some i18n and cloud backup changes

* backups: show back up state (#5420)

* chore: rug portfolio websocket (#5371)

* rug portfolio websocket

* cleanup

* rug it all

---------

Co-authored-by: skylarbarrera <skylar.barrera@gmail.com>

* skylar did all this

* change backupProvider to be served from user data and not local wallet state

* fix stuff

* cleanup merge

* txSim: price clean up (#5411)

* save

* swaps: fix max native check (#5399)

* audit: undici (#5419)

* fin

* clean up

* only save local password if we dont have

* finish piping up title

---------

Co-authored-by: Derek Nelson <6868432+dereknelson@users.noreply.github.com>
Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>

* impl. backing up all wallets at once (#5432)

* progress

* backup all wallets progress

* add some logging

* Update src/screens/Diagnostics/index.tsx

* .

* Fix Android google drive login quirks (#5461)

* fix android stuff

* fix lint

* rev pbx

* /

* Fix Android ShadowStack causing TextInputs to be funky... and not in a fun way (#5478)

* fix some i18n

* add cloudPlatform to description

* mother of god

* undo test changes

* added assets to xcode

* fix files (#5468)

* Add this wallet sheet doesn't dismiss after backing up to iCloud (#5467)

* fix goBack not being called on backup success

* return success

* fix view cloud backups not working (#5466)

* Android only - previous back up with pin code requires a new creation each time to view (#5482)

* temp change

* change validPin flag when biometrics fails to decrypt

* Fixes to Android Google Account Management (#5476)

* lots of android account changing fixes

* remove log

* remove remoteProvider

* i18n

* test signing key

* init (#5507)

* fix android pin flow

* restore to backup changes

* restore changes

* fix lint

* restoration changes

* getprivatekey call changes

* smol cleanup on keychain

* rm log

* fix current backup not being restored into keychain properly

* add keychain logging

* some backups issues solved

* fix some longstanding android old pin decryption and create wallet not prioritizing seed phrases

* remove unused lodash import and console logs

* final restoration changes

* fix backup prompt not working since it wasn't wrapped in the provider

* undo commit to nfts query

* add login if needed on android

* fix no provider modal

* rm xcode assets

* Update src/components/backup/BackupCloudStep.tsx

Co-authored-by: Bruno Barbieri <1247834+brunobar79@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Bruno Barbieri <1247834+brunobar79@users.noreply.github.com>

* remove keychain logging stuff

* fix lint

* fix i18n paths

---------

Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com>
Co-authored-by: Derek Nelson <6868432+dereknelson@users.noreply.github.com>
Co-authored-by: Derek <dereknelsony0@gmail.com>
Co-authored-by: Bruno Barbieri <1247834+brunobar79@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants