Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points: notifications toggle #5329

Merged
merged 19 commits into from Jan 20, 2024
Merged

Conversation

benisgold
Copy link
Member

@benisgold benisgold commented Jan 17, 2024

Fixes APP-1038

What changed (plus any additional context for devs)

  • refactored notifications infra to accommodate configurability for notifications that are device-based, NOT wallet-based
  • added toggle for points notifications in notifications settings
  • added toggle for points notifications in points tab

Screen recordings / screenshots

tested android too just didn't record video
https://github.com/rainbow-me/rainbow/assets/15272675/1a1d124f-0aa1-4331-bdc4-9ad6de55dc5c

What to test

  • TF 1.9.14 (22)
  • would be helpful if anyone wanted to test actual notification functionality, hmu if you're interested

@ibrahimtaveras00 ibrahimtaveras00 added the release for release blockers and release candidate branches label Jan 18, 2024
@benisgold benisgold changed the title @benisgold/points notifications Points: notifications toggle Jan 18, 2024
Copy link

linear bot commented Jan 18, 2024

@benisgold benisgold marked this pull request as ready for review January 18, 2024 18:54
@benisgold benisgold force-pushed the @benisgold/points-notifications branch from 2c40428 to 809787a Compare January 18, 2024 22:18
Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benisgold benisgold merged commit fb71200 into develop Jan 20, 2024
6 checks passed
@benisgold benisgold deleted the @benisgold/points-notifications branch January 20, 2024 20:03
walmat added a commit that referenced this pull request Jan 26, 2024
* [APP-1051]: (feat): add backups global config (#5306)

* (feat): add backups global config

* stash

* add migration for setting initial backup method

* add method to migrations array

* revert pbx change

* change backup status value

* chore: hide testnet settings (#5308)

* remote testnet settings

* trying this

* switch to breadcrumbs (#5309)

* switch to breadcrumbs

* change to debug calls

* . (#5311)

* bump version to v1.9.14 (#5312)

* [APP-1052]: Add icon to Settings depending on `preferredBackupMethod` and `backupStatus` (#5313)

* [APP-1052]: (feat): adjust settings page row

* fix migration and hook for useWallets

* simplify an if statement

* chore: fix CI (#5307)

* disable deeplinks jest tests

* try this

* disable

* oop

* anotha 1

* oop

* swap changes

* e2e for swap flow changes

* testing

* yes

* revert file names

* yup

* audit: follow-redirects (#5323)

* audit mmkv (#5325)

* wallets and backups screen progress (#5315)

* wallets and backups screen progress

* manual backups progress

* progress

* feat(backups): more work on wallets and backups

* revert pbx

* rev init wallet change

* final touches on wallets and backup view

* f (#5327)

* bump react-native-linear-gradient (#5328)

* CHANGE: upgrade camera package to react-native-vision-camera FIX: [APP-171], [APP-776] (#5178)

* init

* init

* more

* GRR!!! BARK BARK

* fixes

* revert

* fix

* changes

* changes

* hoist

* hook

* comment

* fix

* i actually did it

* cleanup 1

* get android build working

* remove old package

* move back to hook

* .

* .

* .

* build

* build fix

* provisioning profiles

* bump ios version

* .

* .

* oops

* language change

* final fixes

* Update project.pbxproj

---------

Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me>
Co-authored-by: skylarbarrera <skylar.barrera@gmail.com>

* [APP-925]: Backend Driven Cards (#5198)

* add experimental flag for remote cards (#5196)

* [APP-929]: Add `RemoteCardProvider` and react-query calls (#5197)

* add card and cardCollection to arc

* rm logs

* [APP-930]: Add `<RemoteCard />` component (#5203)

* start progress on remote card

* update remote card

* [APP-932]: Add `<RemoteCardCarousel />` component (#5205)

* added card carousel to wallet and discover screen

* update card and package

* tweaks to make carousel fit in

* update styles

* idkwtfiad

* disable scroll when only one card is present and adjust view dimensions size based on card length

* .

* fix layout issues

* remove unused debuglayout

* fix card and re-enable check to not show cards again

* Apply suggestions from code review

* tweak discover page

* add some testing edge cases

* add remote config stuff

* fix graphql schema

* code review changes

* change to new remote config hook

* fix remote config

* new design

* start with view weekly earnings flow

* progress on points breakdown from last week

* Delete ios/.xcode.env.local

* Update src/components/asset-list/RecyclerAssetList2/core/ViewDimensions.tsx

* Update src/components/asset-list/RecyclerAssetList2/core/getLayoutProvider.tsx

* Apply suggestions from code review

* chore: rm snap carousel

* Update shim.js

* finish earnings screen

* finish spec

* adjust gutter size depending on how many cards are in the carousel

* clean unused import

* fix font weight on android and conditionally wrap remote card if primary button has action

* fix recycler list view blank space for watched wallets

* adjust card to prev card on dismissal

* fix text formatting

* fix: lint

* change gutter size

* fix text truncation

* fix ios touch event overlap

* fix: disable hiding cards in dev

* Update src/components/cards/remote-cards/RemoteCardProvider.tsx

* weekly earnings fix and leaderboard diff (#5330)

* fix weekly earnings total

* leaderboard ranking diff

* Update src/screens/points/content/PointsContent.tsx

Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>

---------

Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>

* filter & reduce

---------

Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me>
Co-authored-by: skylarbarrera <skylar.barrera@gmail.com>

* bump: fastlane (#5331)

* Points: rank card fixes (#5332)

* fixes

* fix ens display

* Points: notifications toggle (#5329)

* cleanup unused stuff and progress on backups flow

* rename points topic (#5334)

* rename points topic

* Update constants.ts

---------

Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com>

* backups: warning + new secret phrase styles (#5322)

* save progress

* cleanup and finish secret phrase / private key viewiing screens

---------

Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>

* chore: cleanup WalletsAndBackup settings screen and replace lang with i18n

* bump minSdkVersion (#5337)

* android settings fixes

* progress on cloud backup flow

* cloud backup flow progress

---------

Co-authored-by: Skylar Barrera <skylar.barrera@gmail.com>
Co-authored-by: brdy <41711440+BrodyHughes@users.noreply.github.com>
Co-authored-by: Ibrahim Taveras <ibrahim@rainbow.me>
Co-authored-by: Ben Goldberg <bengoldberg@rainbow.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rainbow points release for release blockers and release candidate branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants