Browser: fully eliminate reloading issues #5576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(This prevents the URL in the SearchInput from updating correctly in certain cases - will need to address another way)
Can now pass a shared value string as the sole child of AnimatedText
christianbaroni
requested review from
brunobar79,
skylarbarrera and
benisgold
as code owners
Co-authored-by: Bruno Barbieri <1247834+brunobar79@users.noreply.github.com>
skylarbarrera
approved these changes
Mar 29, 2024
BrodyHughes
added a commit
that referenced
this pull request
Apr 2, 2024
* 'develop' of github.com:rainbow-me/rainbow: Only hold the active tab ref in BrowserContext (#5579) Dapp browser: disable tab closing for empty state (#5573) Browser: fix ref assignment, back/forward navigation (#5578) Browser: fully eliminate reloading issues (#5576) browser: static trending dapps (#5561) bump swaps sdk (#5574) fix gitignore (#5571) bump (#5570) Fix browser context menu not updating (#5569) ⚡️ Fast browser (#5566) [APP-1049]: (feat): Backups V2 (#5310) fix: search by contract address (#5563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Screen recordings / screenshots
RPReplay_Final1711622304.mp4
What to test