Browser: remove webviewRefs #5579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianbaroni
requested review from
brunobar79,
skylarbarrera and
benisgold
as code owners
brunobar79
approved these changes
Apr 2, 2024
skylarbarrera
approved these changes
Apr 2, 2024
BrodyHughes
added a commit
that referenced
this pull request
Apr 2, 2024
* 'develop' of github.com:rainbow-me/rainbow: Only hold the active tab ref in BrowserContext (#5579) Dapp browser: disable tab closing for empty state (#5573) Browser: fix ref assignment, back/forward navigation (#5578) Browser: fully eliminate reloading issues (#5576) browser: static trending dapps (#5561) bump swaps sdk (#5574) fix gitignore (#5571) bump (#5570) Fix browser context menu not updating (#5569) ⚡️ Fast browser (#5566) [APP-1049]: (feat): Backups V2 (#5310) fix: search by contract address (#5563)
BrodyHughes
added a commit
that referenced
this pull request
Apr 10, 2024
…e-changes * 'develop' of github.com:rainbow-me/rainbow: (44 commits) allow open in new tab (#5610) added warning for unknown price impact (#5597) fix cloudflare protection (#5609) improve type checking on web preferences (#5607) fix scrolltoindex firing on last card dismissal (#5606) make account network switcher work (#5604) Dapp browser fixes (#5596) Fix close tab btn (#5598) browser: add account context menu (#5603) Fix instant screenshot setting (#5602) swaps: bump sdk (#5583) Browser: tab transitions, state update queue (#5582) audit: undici (#5594) [SWAPS V2]: Add token search logic and ability to select assets (#5547) swaps v2 gas (#5526) tx sim: other natives (#5585) Brody/bump 1.9.21 3 (#5588) fix sheet bg (#5590) Only hold the active tab ref in BrowserContext (#5579) Dapp browser: disable tab closing for empty state (#5573) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
webViewRefsentirely — no reason to hold all of the refs in the context as far as I can tellactiveTabReftakes its place and is assigned the correct ref from the tab itself when that tab becomes activeScreen recordings / screenshots
What to test