Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser: fix ref assignment, back/forward navigation #5578

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Browser: fix ref assignment, back/forward navigation #5578

merged 2 commits into from
Mar 30, 2024

Conversation

christianbaroni
Copy link
Member

What changed (plus any additional context for devs)

  • This fixes the issues causing the link to the active tab ref to break in certain cases, particularly when going from the homepage to a URL
    • The ref (with a null value) was being set in webViewRefs in certain cases before the WebView was mounted, for instance when going from the homepage to a website
  • Added a forward button to the context menu
  • Reloading should now always work
  • Back/forward buttons should now show and work correctly, and persist through reloads and tab switches

What to test

brunobar79
brunobar79 approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christianbaroni christianbaroni merged commit fb3d0eb into develop Mar 30, 2024
5 of 6 checks passed
@christianbaroni christianbaroni deleted the @christian/webview-ref-navigation-fixes branch March 30, 2024 01:32
BrodyHughes added a commit that referenced this pull request Apr 2, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into develop
9d797dd 
* 'develop' of github.com:rainbow-me/rainbow:
  Only hold the active tab ref in BrowserContext (#5579)
  Dapp browser: disable tab closing for empty state (#5573)
  Browser: fix ref assignment, back/forward navigation (#5578)
  Browser: fully eliminate reloading issues (#5576)
  browser: static trending dapps (#5561)
  bump swaps sdk (#5574)
  fix gitignore (#5571)
  bump (#5570)
  Fix browser context menu not updating (#5569)
  ⚡️ Fast browser (#5566)
  [APP-1049]: (feat): Backups V2 (#5310)
  fix: search by contract address (#5563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

@skylarbarrera skylarbarrera Awaiting requested review from skylarbarrera

@benisgold benisgold Awaiting requested review from benisgold

Assignees
No one assigned
Labels
dapp browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christianbaroni @brunobar79