Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type checking and error handling on web preferences #5607

Merged
merged 1 commit into from Apr 9, 2024
Merged

Improve type checking and error handling on web preferences #5607

merged 1 commit into from Apr 9, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Apr 8, 2024

No description provided.

skylarbarrera
skylarbarrera approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

king

@walmat walmat merged commit 81438be into develop Apr 9, 2024
6 checks passed
@walmat walmat deleted the @matthew/fix-showcase-oob branch April 9, 2024 15:47
BrodyHughes added a commit that referenced this pull request Apr 10, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/e2…
76addf0 
…e-changes

* 'develop' of github.com:rainbow-me/rainbow: (44 commits)
  allow open in new tab (#5610)
  added warning for unknown price impact (#5597)
  fix cloudflare protection (#5609)
  improve type checking on web preferences (#5607)
  fix scrolltoindex firing on last card dismissal (#5606)
  make account network switcher work (#5604)
  Dapp browser fixes (#5596)
  Fix close tab btn (#5598)
  browser: add account context menu (#5603)
  Fix instant screenshot setting (#5602)
  swaps: bump sdk (#5583)
  Browser: tab transitions, state update queue (#5582)
  audit: undici (#5594)
  [SWAPS V2]: Add token search logic and ability to select assets (#5547)
  swaps v2 gas (#5526)
  tx sim: other natives (#5585)
  Brody/bump 1.9.21 3 (#5588)
  fix sheet bg (#5590)
  Only hold the active tab ref in BrowserContext (#5579)
  Dapp browser: disable tab closing for empty state (#5573)
  ...
BrodyHughes added a commit that referenced this pull request Apr 10, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into develop
c5cc83f 
* 'develop' of github.com:rainbow-me/rainbow:
  allow open in new tab (#5610)
  added warning for unknown price impact (#5597)
  fix cloudflare protection (#5609)
  improve type checking on web preferences (#5607)
  fix scrolltoindex firing on last card dismissal (#5606)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylarbarrera skylarbarrera skylarbarrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@walmat @skylarbarrera