Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser: browserStore #5669

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Browser: browserStore #5669

merged 2 commits into from
Apr 26, 2024

Conversation

christianbaroni
Copy link
Member

What changed (plus any additional context for devs)

  • First part of the new browser architecture
  • Creates browserStore, which is used to manage and persist the browser state
  • Uses a new custom zustand+MMKV store purpose-built for the browser data, with lazy serialization and background persistence
  • Leverages latest zustand APIs
  • Handles the necessary conversion of the tabsData Map to an Array when persisting and reading from storage, since JSON serialization doesn't handle them properly by default
  • We can probably extract some of this to make it reusable and improve our other stores

Screen recordings / screenshots

What to test

brunobar79
brunobar79 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@christianbaroni christianbaroni merged commit b19ac26 into develop Apr 26, 2024
5 of 6 checks passed
@christianbaroni christianbaroni deleted the @christian/browser-new-architecture branch April 26, 2024 00:05
@christianbaroni christianbaroni restored the @christian/browser-new-architecture branch April 26, 2024 00:31
@christianbaroni christianbaroni mentioned this pull request Apr 26, 2024
Merged
8 tasks
BrodyHughes added a commit that referenced this pull request May 3, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/ma…
284f5e1 
…estro-test

* 'develop' of github.com:rainbow-me/rainbow:
  createRainbowStore (#5689)
  Browser: new architecture (#5671)
  handle injection natively (#5677)
  fix wallet balance in send flow (#5665)
  bump version to v1.9.23 (#5668)
  use current safari UA (#5670)
  Browser: browserStore (#5669)
BrodyHughes added a commit that referenced this pull request May 7, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/de…
11f252f 
…eplink-add

* 'develop' of github.com:rainbow-me/rainbow: (22 commits)
  disable sentry (#5707)
  fix favorites list issues (#5659)
  fix: learn more webview clipped (#5687)
  add explorer_url and explorer_label to txn types and consume (#5690)
  Add names to wallet list info in backups v2 (#5692)
  feat: upgrading swap sdk to 0.19.0 (#5694)
  Add documentation (#5701)
  Fix supported chains bugs (#5697)
  useAnimatedTime, useAnimatedInterval, useAnimatedTimeout (#5699)
  hey (#5686)
  browser bugs (#5695)
  useSharedValueState (#5698)
  Connect Panel improvements (#5693)
  createRainbowStore (#5689)
  Browser: new architecture (#5671)
  handle injection natively (#5677)
  fix wallet balance in send flow (#5665)
  bump version to v1.9.23 (#5668)
  use current safari UA (#5670)
  Browser: browserStore (#5669)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

@greg-schrammel greg-schrammel Awaiting requested review from greg-schrammel

@skylarbarrera skylarbarrera Awaiting requested review from skylarbarrera

@benisgold benisgold Awaiting requested review from benisgold

Assignees
No one assigned
Labels
dapp browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christianbaroni @brunobar79 @jinchung