Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useSharedValueState #5698

Merged
merged 1 commit into from
May 5, 2024
Merged

Conversation

christianbaroni
Copy link
Member

@christianbaroni christianbaroni commented May 4, 2024

What changed (plus any additional context for devs)

  • Adds a new hook called useSharedValueState which is a simpler one-directional abstraction on top of useSyncSharedValue
  • Removes old duplicate useSyncSharedValue
  • Switches default compare depth to deep, since it'll skip deeper checks when not needed

Example:

const state = useSharedValueState(sharedValue);

Screen recordings / screenshots

What to test

@christianbaroni christianbaroni merged commit d5b9227 into develop May 5, 2024
5 of 6 checks passed
@christianbaroni christianbaroni deleted the @christian/use-shared-value-state branch May 5, 2024 18:13
BrodyHughes added a commit that referenced this pull request May 7, 2024
…eplink-add

* 'develop' of github.com:rainbow-me/rainbow: (22 commits)
  disable sentry (#5707)
  fix favorites list issues (#5659)
  fix: learn more webview clipped (#5687)
  add explorer_url and explorer_label to txn types and consume (#5690)
  Add names to wallet list info in backups v2 (#5692)
  feat: upgrading swap sdk to 0.19.0 (#5694)
  Add documentation (#5701)
  Fix supported chains bugs (#5697)
  useAnimatedTime, useAnimatedInterval, useAnimatedTimeout (#5699)
  hey (#5686)
  browser bugs (#5695)
  useSharedValueState (#5698)
  Connect Panel improvements (#5693)
  createRainbowStore (#5689)
  Browser: new architecture (#5671)
  handle injection natively (#5677)
  fix wallet balance in send flow (#5665)
  bump version to v1.9.23 (#5668)
  use current safari UA (#5670)
  Browser: browserStore (#5669)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants