Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix supported chains bugs #5697

Merged
merged 3 commits into from
May 6, 2024
Merged

Fix supported chains bugs #5697

merged 3 commits into from
May 6, 2024

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented May 3, 2024

Fixes APP-1409

What changed (plus any additional context for devs)

  • We were not accepting chainIds in hex format (etherscan does that) which was causing the incorrect "unsupported chain id" message.
  • Match the behavior with the BX where we ask the user to start a session first before we're able to switch chains.

Screen recordings / screenshots

Screen.Recording.2024-05-03.at.6.08.03.PM.mov

What to test

Copy link

linear bot commented May 3, 2024

Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖖

@brunobar79 brunobar79 merged commit b8928db into develop May 6, 2024
5 of 6 checks passed
@brunobar79 brunobar79 deleted the @bruno/fix-chainid-supported branch May 6, 2024 19:03
BrodyHughes added a commit that referenced this pull request May 7, 2024
…eplink-add

* 'develop' of github.com:rainbow-me/rainbow: (22 commits)
  disable sentry (#5707)
  fix favorites list issues (#5659)
  fix: learn more webview clipped (#5687)
  add explorer_url and explorer_label to txn types and consume (#5690)
  Add names to wallet list info in backups v2 (#5692)
  feat: upgrading swap sdk to 0.19.0 (#5694)
  Add documentation (#5701)
  Fix supported chains bugs (#5697)
  useAnimatedTime, useAnimatedInterval, useAnimatedTimeout (#5699)
  hey (#5686)
  browser bugs (#5695)
  useSharedValueState (#5698)
  Connect Panel improvements (#5693)
  createRainbowStore (#5689)
  Browser: new architecture (#5671)
  handle injection natively (#5677)
  fix wallet balance in send flow (#5665)
  bump version to v1.9.23 (#5668)
  use current safari UA (#5670)
  Browser: browserStore (#5669)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants