-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: limit Sentry tracking, fix NFT hooks #5819
Conversation
@@ -72,8 +72,7 @@ const Logger = { | |||
console.log(...args); // eslint-disable-line no-console | |||
} | |||
if (args.length === 1 && typeof args[0] === 'string') { | |||
// @ts-expect-error ts-migrate(2769) FIXME: No overload matches this call. | |||
sentryUtils.addInfoBreadcrumb.apply(null, args); | |||
sentryUtils.addInfoBreadcrumb.apply(null, [args[0]]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
…ap-v2-e2e * 'develop' of github.com:rainbow-me/rainbow: Fix weird issues with rounding (#5822) Fix provider recursion bug, provider function types (#5829) bump braces (#5831) Add entry point for other networks (#5824) remove info icon on max transaction fee row as we don't have that in spec (#5827) [e2e] Add Malicious Dapp interaction test (#5764) reorg ens related calls (#5828) Performance: limit Sentry tracking, fix NFT hooks (#5819) fix wrong chainname (#5823) Disable flashbots toggle on appropriate chains (#5812) add type to SearchAsset type and add into type possibilities (#5820) fix fasterimage border radius android (#5816) more Safemath fixes (#5818)
Fixes APP-1555
Fixes APP-1566
What changed (plus any additional context for devs)
nftsQueryKey
persisterVersion
because the structure ofdata
(from theuseQuery
hook) is now different with the NFT data transformation moved into theuseQuery
.useLegacyNFTs
wrapper hook is unchanged and fully backwards compatible — ideally we later remove the wrapper hook and migrate to the new NFT types.App.js
and in theWalletScreen
componentAlso:
dapps
data from UI components in the browser, because thedapps
object is quite heavy and it's unnecessary for it to cause re-renders in searchScreen recordings / screenshots
What to test