Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Add Malicious Dapp interaction test #5764

Merged
merged 11 commits into from
Jun 7, 2024

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented May 23, 2024

Fixes APP-1461

What changed (plus any additional context for devs)

  • Added test for validating we are showing the malicious dapp warning

Screen recordings / screenshots

  • Flow the test follows:
    Screen.Recording.2024-05-29.at.3.13.10.PM.mov

What to test

  • Does it all pass?

…licious-dapp-warning-e2e

* 'develop' of github.com:rainbow-me/rainbow:
  Swaps: package upgrades, fix SwapBackground and AnimatedSwapSpinner (#5775)
  Swaps: fix safe math negative number support, add comparison functions (#5776)
  Reanimated v3.11.0 (#5683)
  Gas (#5757)
  add degen chain to network selector (#5766)
  prefer local chain image over custom (#5772)
  add safe math fns (#5765)
  filter out assets from curated assets with no icon_url (#5768)
  fix isQuoteStale lag (#5769)
  fix icon sizing (#5771)
  Preliminary work: Update formatter functions to take in object params (#5760)
  APP-1500 (#5763)
  chore: i18n updates (#5762)
Copy link

linear bot commented May 29, 2024

@BrodyHughes BrodyHughes changed the title [WIP] Brody/malicious dapp warning e2e [e2e] Add Malicious Dapp interaction test May 29, 2024
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. nits

e2e/7_maliciousDappConnection.spec.ts Outdated Show resolved Hide resolved
e2e/environment.js Show resolved Hide resolved
Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@walmat walmat merged commit 6f00408 into develop Jun 7, 2024
6 checks passed
@walmat walmat deleted the brody/malicious-dapp-warning-e2e branch June 7, 2024 20:44
BrodyHughes added a commit that referenced this pull request Jun 11, 2024
…ap-v2-e2e

* 'develop' of github.com:rainbow-me/rainbow:
  Fix weird issues with rounding  (#5822)
  Fix provider recursion bug, provider function types (#5829)
  bump braces (#5831)
  Add entry point for other networks (#5824)
  remove info icon on max transaction fee row as we don't have that in spec (#5827)
  [e2e] Add Malicious Dapp interaction test (#5764)
  reorg ens related calls (#5828)
  Performance: limit Sentry tracking, fix NFT hooks (#5819)
  fix wrong chainname (#5823)
  Disable flashbots toggle on appropriate chains (#5812)
  add type to SearchAsset type and add into type possibilities (#5820)
  fix fasterimage border radius android (#5816)
  more Safemath fixes (#5818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants