Add rudimentary support for DWARF5 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows `cv2pdb` to process executables produced by the mingw-w64 version of GCC v11.x. The symptoms of the fixed issue would look like this: error: cannot add line number info to module Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Thanks for your contribution. I'll have to trust you on this change, but I see that older DWARF versions should be unaffected. |
|
Heh, I had hoped that somebody more knowledgeable than I would double-check my work :-) Having said that, I went by the official specs and verified that it works using a freshly-built |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
cv2pdbto process executables produced by the mingw-w64 version of GCC v11.x. The symptoms of the fixed issue would look like this:We will most likely have to run with this patch to allow building Git for Windows henceforth, as we use the mingw-w64 version of GCC provided by the MSYS2 project, and they recently upgraded to GCC v11.x (where it seems impossible to force an older DWARF version via
-gdwarf-<version> -gstrict-dwarf).This fixes git-for-windows/git#3488.