-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI post deploy message does not tell you if stylesheets were uploaded #34
Comments
Thanks for the feature suggestion!
Does that clear it up? Otherwise happy to take this as an idea and see if there's more interest (or accept a PR if you'd like to see it in there). |
I was making changes to the style file and running deploy and not seeing that reflected in the campaign. Now it may have been a syntax error in the scss compiler was aborting the file upload, but I didn’t know and only saw a log of the components being sent. I suppose my question is - why not show the style sheets. Or even just the one compressed one so you know it’s happened. It feels strange to show the components and not the stylesheets. The components will likely make up most of the file tree. |
No I don’t, none were there after I ran ‘raisely init’ , logged in and selected my campaign. I don’t think the QuickStart mentioned it either - I’ll check |
Weird. Maybe none were selected in your case. If you run |
@tommaitland oh damn that’s it! When I ran raisely init I didn’t click space bar to select the campaigns I was interested in, I just arrived over to the one and clicked enter on the campaign I wanted. And because components are agnostic of campaigns when uploading they still deploy. But with no campaign uuid the stylesheets don’t. It’s still very confusing that raisely start (and local) still works, even though there was no uuid in .raisely.json. I’ll run it again with the space bar step. |
Nice – glad that solves it! |
I am wondering if a CLI improvement would be to not allow people to run deploy, start or local without at least one uuid being added to the ‘.raisely.json`. actually I’m still confused as to why local and start still worked? |
|
@tommaitland if it doesn't use I also noticed My task is to develop a new component for a new campaign, so I am only interested in viewing that one in |
The CLI should support multiple scss files as per the docs. So I'd have expected to see a l ist of stylesheet files uploaded/processed in a similar way to the components.
AND if it errors on compiling the stylesheets it should error out and tell you
The text was updated successfully, but these errors were encountered: