Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI post deploy message does not tell you if stylesheets were uploaded #34

Closed
danalexilewis opened this issue Jul 11, 2022 · 10 comments
Closed
Labels
enhancement New feature or request

Comments

@danalexilewis
Copy link

danalexilewis commented Jul 11, 2022

The CLI should support multiple scss files as per the docs. So I'd have expected to see a l ist of stylesheet files uploaded/processed in a similar way to the components.

AND if it errors on compiling the stylesheets it should error out and tell you

image

@tommaitland tommaitland added the enhancement New feature or request label Jul 12, 2022
@tommaitland
Copy link
Contributor

Thanks for the feature suggestion! raisely deploy currently sends everything up – all stylesheet files and all components. We could show the files processed here but it'd essentially be your folder tree.

raisely deploy will show an error and abort if anything breaks – so if a component errors, the whole command will error.

Does that clear it up? Otherwise happy to take this as an idea and see if there's more interest (or accept a PR if you'd like to see it in there).

@danalexilewis
Copy link
Author

I was making changes to the style file and running deploy and not seeing that reflected in the campaign. Now it may have been a syntax error in the scss compiler was aborting the file upload, but I didn’t know and only saw a log of the components being sent.

I suppose my question is - why not show the style sheets. Or even just the one compressed one so you know it’s happened. It feels strange to show the components and not the stylesheets. The components will likely make up most of the file tree.

@tommaitland
Copy link
Contributor

I've just checked the output of raisely deploy on my system and we do give you a simple confirmation that styles have uploaded successfully for each campaign:

image

Perhaps this is instead a bug with your setup, do you have any campaign UUIDs in your .raisely.json file?

@danalexilewis
Copy link
Author

Perhaps this is instead a bug with your setup, do you have any campaign UUIDs in your .raisely.json file?

No I don’t, none were there after I ran ‘raisely init’ , logged in and selected my campaign.

I don’t think the QuickStart mentioned it either - I’ll check

@tommaitland
Copy link
Contributor

Weird. raisely init asks you to select campaigns, you need to use your arrow keys and then spacebar to select.

Maybe none were selected in your case. If you run raisely init again you should be able to select campaigns then their styles should show on the project directory.

@danalexilewis
Copy link
Author

@tommaitland oh damn that’s it! When I ran raisely init I didn’t click space bar to select the campaigns I was interested in, I just arrived over to the one and clicked enter on the campaign I wanted.

And because components are agnostic of campaigns when uploading they still deploy. But with no campaign uuid the stylesheets don’t.

It’s still very confusing that raisely start (and local) still works, even though there was no uuid in .raisely.json.

I’ll run it again with the space bar step.

@tommaitland
Copy link
Contributor

Nice – glad that solves it!

@danalexilewis
Copy link
Author

I am wondering if a CLI improvement would be to not allow people to run deploy, start or local without at least one uuid being added to the ‘.raisely.json`.

actually I’m still confused as to why local and start still worked?

@tommaitland
Copy link
Contributor

local doesn't use the details in .raisely.json since you can run it for any campaign and just work on components. Start would be the same, but should only work for components. I might be wrong there, been a while since I checked that code. Was that different to what you saw?

@danalexilewis
Copy link
Author

@tommaitland if it doesn't use .raisely.json can you clarify how I specify which campaign local or start uses? ie how do I view my components in the context of different campaigns.

I also noticed start does deploy scss files, so its not just compoenents.

My task is to develop a new component for a new campaign, so I am only interested in viewing that one in local and when using start. In the future I may be working on other campaigns and need to view the components in that other context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants