Second attempt at ng16 upgrade #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ng update @angular/animations@15 @angular/cdk@15 @angular/common@15 @angular/compiler@15 @angular/core@15 @angular/forms@15 @angular/material@15 @angular/platform-browser@15 @angular/platform-browser-dynamic@15 @angular/router@15
ng update @angular/animations@16 @angular/cdk@16 @angular/common@16 @angular/compiler@16 @angular/core@16 @angular/forms@16 @angular/material@16 @angular/platform-browser@16 @angular/platform-browser-dynamic@16 @angular/router@16 @angular/compiler-cli@16 @angular/language-service@16 @angular-devkit/build-angular@16
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -4,7 +4,7 @@ import { RouterModule } from '@angular/router'; | |||
| import { CommonModule } from '@angular/common'; | |||
| import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; | |||
| import { MatToolbarModule } from '@angular/material/toolbar'; | |||
| import { MatListModule } from '@angular/material/list'; | |||
There was a problem hiding this comment.
Added by migration script when running ng update
| @@ -63,7 +63,7 @@ const routes: Routes = [ | |||
| ]; | |||
|
|
|||
| @NgModule({ | |||
| imports: [RouterModule.forRoot(routes, { relativeLinkResolution: 'legacy' })], | |||
There was a problem hiding this comment.
Added by migration script when running ng update
|
By building invidiual components, all four , using ng build I was able to run ng test but it claims some errors, while also being green |
|
We rewrote our components, I have no further interest in pursuing this stale PR so closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried a different way to upgrade using ng update. Still does not work, but likely a better way to get dependencies correct.
Commands are in individual commits, but I ran these
Realized later that I had forgot
ng update @angular/cli@15andng update @angular/cli@16so did that in a separate commit.