Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second attempt at ng16 upgrade #51

Closed
wants to merge 7 commits into from
Closed

Second attempt at ng16 upgrade #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
09243b9
Fix project references to avoid github read issues when npm i
bjorn-einar-bjartnes-4ss Aug 4, 2023
b772d1a
Use ng update to update to v15
bjorn-einar-bjartnes-4ss Aug 4, 2023
5125944
ng update to v16
bjorn-einar-bjartnes-4ss Aug 4, 2023
d8432c7
Ignoring angular folder
bjorn-einar-bjartnes-4ss Aug 4, 2023
4fd3112
ng update @angular/cli@16
bjorn-einar-bjartnes-4ss Aug 4, 2023
e12599f
ng update @angular/cli@16
bjorn-einar-bjartnes-4ss Aug 4, 2023
4827d1c
Upgrade version to 10 to indicate ng 16 compat
bjorn-einar-bjartnes-4ss Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,5 @@ testem.log
Thumbs.db

package-lock.json

/.angular
1 change: 0 additions & 1 deletion angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,6 @@
}
}
},
"defaultProject": "ng7-dynamic-breadcrumb-lib",
"cli": {
"analytics": false
}
Expand Down
44 changes: 22 additions & 22 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,31 +11,31 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^14.0.0" ,
"@angular/cdk": "^14.0.0",
"@angular/common": "^14.0.0",
"@angular/compiler": "^14.0.0",
"@angular/core": "^14.0.0",
"@angular/forms": "^14.0.0",
"@angular/material": "^14.0.0",
"@angular/platform-browser": "^14.0.0",
"@angular/platform-browser-dynamic": "^14.0.0",
"@angular/router": "^14.0.0",
"@angular/animations": "^16.1.8",
"@angular/cdk": "^16.1.7",
"@angular/common": "^16.1.8",
"@angular/compiler": "^16.1.8",
"@angular/core": "^16.1.8",
"@angular/forms": "^16.1.8",
"@angular/material": "^16.1.7",
"@angular/platform-browser": "^16.1.8",
"@angular/platform-browser-dynamic": "^16.1.8",
"@angular/router": "^16.1.8",
"bootstrap": "^4.3.1",
"core-js": "^3.1.3",
"ng-dynamic-breadcrumb": "projects/ng-dynamic-breadcrumb",
"ng7-bootstrap-breadcrumb": "projects/ng7-bootstrap-breadcrumb",
"ng7-dynamic-breadcrumb": "projects/ng7-dynamic-breadcrumb",
"ng7-mat-breadcrumb": "projects/ng7-mat-breadcrumb",
"ng-dynamic-breadcrumb": "./projects/ng-dynamic-breadcrumb",
"ng7-bootstrap-breadcrumb": "./projects/ng7-bootstrap-breadcrumb",
"ng7-dynamic-breadcrumb": "./projects/ng7-dynamic-breadcrumb",
"ng7-mat-breadcrumb": "./projects/ng7-mat-breadcrumb",
"rxjs": "~6.6.3",
"tslib": "^2.3.0",
"zone.js": "~0.11.4"
"zone.js": "~0.13.1"
},
"devDependencies": {
"@angular-devkit/build-angular": "^14.0.0",
"@angular/cli": "^14.0.0",
"@angular/compiler-cli": "^14.0.0",
"@angular/language-service": "^14.0.0",
"@angular-devkit/build-angular": "^16.1.7",
"@angular/cli": "^16.1.7",
"@angular/compiler-cli": "^16.1.8",
"@angular/language-service": "^16.1.8",
"@types/jasmine": "~3.8.0",
"@types/jasminewd2": "~2.0.3",
"@types/node": "^14.0.0",
Expand All @@ -47,14 +47,14 @@
"karma-coverage-istanbul-reporter": "~3.0.2",
"karma-jasmine": "~4.0.0",
"karma-jasmine-html-reporter": "^1.5.0",
"ng-packagr": "^14.0.0",
"ng-packagr": "^16.1.0",
"protractor": "~7.0.0",
"ts-node": "~8.2.0",
"tslint": "~6.1.0",
"typescript": "^4.2.3"
"typescript": "^5.1.6"
},
"author": "Raja Rama Mohan Thavalam",
"contributors": [
"Raja Rama Mohan Thavalam <rajarm.tavalam@gmail.com>"
]
}
}
13 changes: 6 additions & 7 deletions projects/ng-dynamic-breadcrumb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "ng-dynamic-breadcrumb",
"description": "Angular 14 Dynamic Breadcrumb",
"version": "8.0.0",
"description": "Angular 16 Dynamic Breadcrumb",
"version": "10.0.0",
"peerDependencies": {
"@angular/common": "^14.0.0",
"@angular/core": "^14.0.0"
"@angular/common": "^16.0.0",
"@angular/core": "^16.0.0"
},
"main": "bundles/ng-dynamic-breadcrumb.umd.js",
"module": "fesm5/ng-dynamic-breadcrumb.js",
Expand Down Expand Up @@ -45,9 +45,8 @@
"angular 11 Breadcrumbs",
"angular12 Breadcrumbs",
"angular 12 Breadcrumbs",
"angular 14 Breadcrumbs"


"angular 14 Breadcrumbs",
"angular 16 Breadcrumbs"
],
"bugs": {
"url": "https://github.com/rajaramtt/ng7-dynamic-breadcrumb/issues"
Expand Down
6 changes: 0 additions & 6 deletions projects/ng-dynamic-breadcrumb/src/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,8 @@ import {
platformBrowserDynamicTesting
} from '@angular/platform-browser-dynamic/testing';

declare const require: any;

// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(
BrowserDynamicTestingModule,
platformBrowserDynamicTesting()
);
// Then we find all the tests.
const context = require.context('./', true, /\.spec\.ts$/);
// And load the modules.
context.keys().map(context);
1 change: 0 additions & 1 deletion projects/ng-dynamic-breadcrumb/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"outDir": "../../out-tsc/lib",
"declarationMap": true,
"target": "es2015",
"declaration": true,
"inlineSources": true,
"types": [],
Expand Down
11 changes: 6 additions & 5 deletions projects/ng7-bootstrap-breadcrumb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "ng7-bootstrap-breadcrumb",
"description": "Angular 14 bootstrap Dynamic Breadcrumb",
"version": "8.0.0",
"description": "Angular 16 bootstrap Dynamic Breadcrumb",
"version": "10.0.0",
"peerDependencies": {
"@angular/common": "^14.0.0",
"@angular/core": "^14.0.0",
"@angular/common": "^16.0.0",
"@angular/core": "^16.0.0",
"bootstrap": "^4.3.1"
},
"main": "bundles/ng7-dynamic-breadcrumb.umd.js",
Expand Down Expand Up @@ -48,7 +48,8 @@
"angular11 Breadcrumbs",
"angular 11 Breadcrumbs",
"angular12 Breadcrumbs",
"angular 14 Breadcrumbs"
"angular 14 Breadcrumbs",
"angular 16 Breadcrumbs"
],
"bugs": {
"url": "https://github.com/rajaramtt/ng7-dynamic-breadcrumb/issues"
Expand Down
6 changes: 0 additions & 6 deletions projects/ng7-bootstrap-breadcrumb/src/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,8 @@ import {
platformBrowserDynamicTesting
} from '@angular/platform-browser-dynamic/testing';

declare const require: any;

// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(
BrowserDynamicTestingModule,
platformBrowserDynamicTesting()
);
// Then we find all the tests.
const context = require.context('./', true, /\.spec\.ts$/);
// And load the modules.
context.keys().map(context);
1 change: 0 additions & 1 deletion projects/ng7-bootstrap-breadcrumb/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"outDir": "../../out-tsc/lib",
"declarationMap": true,
"target": "es2015",
"module": "es2015",
"moduleResolution": "node",
"declaration": true,
Expand Down
11 changes: 6 additions & 5 deletions projects/ng7-dynamic-breadcrumb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"name": "ng7-dynamic-breadcrumb",
"description": "Angular 14 Dynamic Breadcrumb",
"version": "8.0.0",
"description": "Angular 16 Dynamic Breadcrumb",
"version": "10.0.0",
"peerDependencies": {
"@angular/common": "^14.0.0",
"@angular/core": "^14.0.0"
"@angular/common": "^16.0.0",
"@angular/core": "^16.0.0"
},
"main": "bundles/ng7-dynamic-breadcrumb.umd.js",
"module": "fesm5/ng7-dynamic-breadcrumb.js",
Expand Down Expand Up @@ -44,7 +44,8 @@
"angular11 Breadcrumbs",
"angular 11 Breadcrumbs",
"angular12 Breadcrumbs",
"angular 14 Breadcrumbs"
"angular 14 Breadcrumbs",
"angular 16 Breadcrumbs"

],
"bugs": {
Expand Down
6 changes: 0 additions & 6 deletions projects/ng7-dynamic-breadcrumb/src/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,8 @@ import {
platformBrowserDynamicTesting
} from '@angular/platform-browser-dynamic/testing';

declare const require: any;

// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(
BrowserDynamicTestingModule,
platformBrowserDynamicTesting()
);
// Then we find all the tests.
const context = require.context('./', true, /\.spec\.ts$/);
// And load the modules.
context.keys().map(context);
1 change: 0 additions & 1 deletion projects/ng7-dynamic-breadcrumb/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"outDir": "../../out-tsc/lib",
"declarationMap": true,
"target": "es2015",
"module": "es2015",
"moduleResolution": "node",
"declaration": true,
Expand Down
13 changes: 7 additions & 6 deletions projects/ng7-mat-breadcrumb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"name": "ng7-mat-breadcrumb",
"description": "Angular 14 Material Breadcrumb NPM Module",
"version": "8.0.0",
"description": "Angular 16 Material Breadcrumb NPM Module",
"version": "10.0.0",
"peerDependencies": {
"@angular/common": "^14.0.0",
"@angular/core": "^14.0.0",
"@angular/material": "^14.0.0"
"@angular/common": "^16.0.0",
"@angular/core": "^16.0.0",
"@angular/material": "^16.0.0"
},
"license": "MIT",
"repository": {
Expand Down Expand Up @@ -33,7 +33,8 @@
"angular11 Breadcrumbs",
"angular 11 Breadcrumbs",
"angular12 Breadcrumbs",
"angular 14 Breadcrumbs"
"angular 14 Breadcrumbs",
"angular 16 Breadcrumbs"
],
"bugs": {
"url": "https://github.com/rajaramtt/ng7-dynamic-breadcrumb/issues"
Expand Down
2 changes: 1 addition & 1 deletion projects/ng7-mat-breadcrumb/src/lib/ng7-mat-breadcrumb.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { RouterModule } from '@angular/router';
import { CommonModule } from '@angular/common';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { MatToolbarModule } from '@angular/material/toolbar';
import { MatListModule } from '@angular/material/list';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by migration script when running ng update

import { MatLegacyListModule as MatListModule } from '@angular/material/legacy-list';

@NgModule({
declarations: [Ng7MatBreadcrumbComponent],
Expand Down
6 changes: 0 additions & 6 deletions projects/ng7-mat-breadcrumb/src/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,8 @@ import {
platformBrowserDynamicTesting
} from '@angular/platform-browser-dynamic/testing';

declare const require: any;

// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(
BrowserDynamicTestingModule,
platformBrowserDynamicTesting()
);
// Then we find all the tests.
const context = require.context('./', true, /\.spec\.ts$/);
// And load the modules.
context.keys().map(context);
1 change: 0 additions & 1 deletion projects/ng7-mat-breadcrumb/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"outDir": "../../out-tsc/lib",
"declarationMap": true,
"target": "es2015",
"module": "es2015",
"moduleResolution": "node",
"declaration": true,
Expand Down
2 changes: 1 addition & 1 deletion src/app/app-routing.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const routes: Routes = [
];

@NgModule({
imports: [RouterModule.forRoot(routes, { relativeLinkResolution: 'legacy' })],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by migration script when running ng update

imports: [RouterModule.forRoot(routes, {})],
exports: [RouterModule]
})
export class AppRoutingModule {
Expand Down
6 changes: 0 additions & 6 deletions src/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,8 @@ import {
platformBrowserDynamicTesting
} from '@angular/platform-browser-dynamic/testing';

declare const require: any;

// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(
BrowserDynamicTestingModule,
platformBrowserDynamicTesting()
);
// Then we find all the tests.
const context = require.context('./', true, /\.spec\.ts$/);
// And load the modules.
context.keys().map(context);
5 changes: 3 additions & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"moduleResolution": "node",
"experimentalDecorators": true,
"importHelpers": true,
"target": "es5",
"target": "ES2022",
"typeRoots": [
"node_modules/@types"
],
Expand Down Expand Up @@ -42,6 +42,7 @@
"ng-dynamic-breadcrumb/*": [
"dist/ng-dynamic-breadcrumb/*"
]
}
},
"useDefineForClassFields": false
}
}