Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop removing existing comments on the alacritty file #42

Merged
merged 5 commits into from
Sep 21, 2021
Merged

fix: stop removing existing comments on the alacritty file #42

merged 5 commits into from
Sep 21, 2021

Conversation

JuanVqz
Copy link
Collaborator

@JuanVqz JuanVqz commented Sep 15, 2021

closes #30

@JuanVqz JuanVqz mentioned this pull request Sep 15, 2021
Closed
rajasegar
rajasegar requested changes Sep 15, 2021
View reviewed changes
Copy link
Owner

@rajasegar rajasegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, at last YAML.stringify is the problematic code here, good find 👏
Can we please add a test to verify the same?

@JuanVqz
Copy link
Collaborator Author

JuanVqz commented Sep 15, 2021 •
edited
Loading

yes, String did the trick!

I'll add the test in the week

@JuanVqz JuanVqz merged commit 98a5d68 into master Sep 21, 2021
@JuanVqz JuanVqz deleted the keep_comments_on_alacritty branch September 21, 2021 14:26
github-actions bot pushed a commit that referenced this pull request Sep 21, 2021
@semantic-release-bot
release(version): Release 4.1.2 [skip ci]
423c814 
## [4.1.2](v4.1.1...v4.1.2) (2021-09-21)

### Bug Fixes

* stop removing existing comments on the alacritty file ([#42](#42)) ([98a5d68](98a5d68)), closes [#30](#30)
@rajasegar
Copy link
Owner

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajasegar rajasegar rajasegar requested changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Applying a theme removes all comments in alacritty.yml
3 participants
@JuanVqz @rajasegar @comonadd