Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinuation of library #1

Closed
divmgl opened this issue Dec 12, 2015 · 2 comments
Closed

Discontinuation of library #1

divmgl opened this issue Dec 12, 2015 · 2 comments

Comments

@divmgl
Copy link

divmgl commented Dec 12, 2015

Hello,

Any reason why you chose to discontinue the library? We can definitely improve it together and it would be a nice project to tackle. There are a few things we can do to improve it (I'm almost done with the initial improvements):

  • Dependence on HttpContext, which can be circumvented using TcpListener
  • Game state design can be improved to use Enum and built-in .NET types
  • UacHelper needs to be completely removed
  • Test project that tests public API

We can make it much better than @master117's library. Let me know.

@rakijah
Copy link
Owner

rakijah commented Dec 13, 2015

Hi,

I've realised that my approach to this was entirely overcomplicated (in it's current state, the library is basically just a wrapper for a JObject).
When I started working on this, I initially used a TcpListener instead of the current HttpListener. The problem was that ~100 TcpClients were being accepted every second, even though there should have been <1. I switched to the HttpListener after I couldn't figure out why this was happening.
Enums were exactly what I was planning to implement to increase usability, but it didn't seem feasible with the current approach.

I'm not really willing to put more energy into this project when I know that there are much more competent developers out there that have already released similar libraries.

@divmgl
Copy link
Author

divmgl commented Dec 13, 2015

Okay, sounds good, although I wouldn't say @master117's library is any better at all. It is a basic wrapper around HttpListener and doesn't even parse JSON. Thanks for your time.

@divmgl divmgl closed this as completed Dec 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants