Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Warning message" from some trackers when a torrent isn't registered. #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

montoner0
Copy link

@montoner0 montoner0 commented Jun 4, 2019

Some trackers send "warning message" instead of a failure when a torrent is not registered on the tracker. Looks like this:

d8:intervali3030e12:min intervali3030e5:peers6:S‹™жЊЄ15:warning message22:Torrent not registerede

The change will turn this warning into an error.

@montoner0 montoner0 marked this pull request as ready for review June 4, 2019 22:58
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 17.889% when pulling 39f4ec8 on montoner0:master into 3a6a61a on rakshasa:master.

@rakshasa
Copy link
Owner

rakshasa commented Jun 8, 2019

warning message: (new, optional) Similar to failure reason, but the response still gets processed normally. The warning message is shown just like an error.

I don't think it would be correct to fail the tracker reply based on words in the warning message, it should instead have a way of both processing the reply and displaying the message in the client.

@montoner0
Copy link
Author

Agree, it would be nice to have some more flexible solution. But for know, as a quick hack it should be enough. Or it would be better to register this as an issue?

…ent is not registered on a tracker. Will show this message as an error.
@kannibalox
Copy link

I'm guessing the one of the reasons tracker admins were even using warning message instead of failure message was to work around rTorrent's behavior of ignoring intervals on properly-bencoded tracker failures. Merging this would mean it would go back to the "announce every 300 seconds" pattern, instead of the 3030 being requested in the response you posted. I've opened a PR here to tell libtorrent to respect min interval here #246, but even with that fix, I'm not sure it's worth playing whack-a-mole in terms of which keys are error codes and which aren't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants