Respect min interval returned by the tracker for failed announces #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannibalox
force-pushed
the
feature/respect-fail-interval
branch
from
c033b5e
to
fb1d45f
Compare
This makes a slightly larger change to the error handling logic, for the sake of keeping the base behavior while still preserving the ABI. Now anything that returns an unparseable failure goes through the normal backoff procedure, but maxes out at 299 seconds instead of 320.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default values for the base class to
0, and relies on the successful parsing of an announce to set them to something sane. If the interval can't be parsed during a failure (from an unrelated failure or just the keys missing), it fails back to the original backoff behavior. However, in order to accommodate the previous logic without modifying the ABI, the backoff timeout is capped at 299 seconds instead of 320.Fixes #1215