download automatically stop on finish

[artifexor]

Latest git revision on FreeBSD 8.2. When download is finished rtorrent stop the torrent. No schedule for this. What interesting that it writes as stopped but I can press ctrl-d for "real" stop and ctrl-d again for remove torrent from list.

[rakshasa]

What was the last revision that worked for you?

Also, what 'finished' related scheduled commands do you have, and do you have hash on completion disabled?

[rakshasa]

I've got this bug too, so once I finish what I'm working on atm I'll look into it.

[artifexor]

I am "happy" for this news as I do not know what was the latest working revision. I have no active finished schedule in my config just a commented one. Is there any command to list active schedule lines in running rtorrent?

[rakshasa]

Should be possible with "method.rlookup = event.download.finished".

[blaenk]

@rakshasa: If you're not aware of what the last version was before it stopped working, it sounds like just the job for git bisect. It basically lets you do an interactive binary search through your commits to find the culprit regression. You probably already knew about this, but I figured I'd mention it in case you forgot or didn't already know. It should make finding the issue a lot easier :)

It's very straightforward. You start by saying the latest commit is bad (or you specify an older one you know is good), and then it switches you to a different commit and you basically tell it if it works or not, until you arrive at the bad commit.

References:

• Finding Issues - Git Bisect
• Debugging with Git

[Novik]

1. Command print=$method.rlookup=event.download.finished in console always print empty string (also if i have registered events).
2. I use last git release with a standard .rtorrent.rc without any schedule or method.set commands (and i don't use any webui). Really .rtorrent.rc contain two lines only:
   directory = ~/torrents/dl
   session = ~/torrents/session
   After dowload and hashing all torrents are setted to "Inactive" state.

[rakshasa]

It returns a map (iirc), which print will not display (iirc).

Well, something like that, I'll need to look closer at the code again.

[blaenk]

@Novik: If you have access to rtorrent's XML-RPC, you can try something like:

$ XML_TRACE_XML=1 xmlrpc path method.rlookup event.download.finished

Where path is up to your configuration (if mounted to HTTP, unix domain socket, etc.).

[rakshasa]

Finally got around to looking at the code, and fixed a rather obvious bug in the DownloadList::confimed_finished code.