Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file tasks should run if one of the dependencies were updated #17

Open
AlexDaniel opened this issue Jun 25, 2018 · 1 comment
Open

file tasks should run if one of the dependencies were updated #17

AlexDaniel opened this issue Jun 25, 2018 · 1 comment
Labels
hacktoberfest

Comments

@AlexDaniel
Copy link
Member

Right now it just checks if file exists, but sometimes a task must run again if some data was updated by dependencies.
@AlexDaniel
Copy link
Member Author

AlexDaniel commented Jun 25, 2018 •
edited
Loading

Actually, now I see that there is some logic in place, but it is limited (e.g. only deps that are paths are supported).

EDIT: or maybe not! Maybe it's ok.

@AlexDaniel AlexDaniel self-assigned this Jul 3, 2018
AlexDaniel added a commit that referenced this issue Oct 6, 2018
@AlexDaniel
💥🤯 Great refactoring, many tests, IO task rework, etc.
8d54732 
Affected tickets:
* Resolves #7: current task is now passed into the block (for both
  normal and IO tasks), with tests.
* Resolves #12: using `run` in sink context now explodes properly
  (tested for both normal and IO tasks).
* Resolves #13: no more shell injection through filenames, tested with
  extra tests for filenames starting with `--`.
* Resolves #16: there are now helper functions to test sakefiles
  without the need to `.execute` tasks from within the test file.  It
  works by creating a temp directory with a given Sakefile and running
  `sake` as external command (stdout, stderr, exit code and signals
  are checked).
* Resolves #18: you can now pass an IO object instead of a Str and it
  will automatically dispatch to the right sub.
* There is some groundwork for #17, and maybe it already works. I
  can't tell if it does because there are no tests for it yet.
* Also some minimal groundwork for #9 (parallel execution).
* Additionally, issue #14 should be more approachable now (because
  deps are now resolved).
* Issue #15 (‘default’ task) was reworked a bit (with no notable
  functional changes).

This commit splits Sake.pm6 into separate files for convenience. The
hierarchy is perhaps not entirely right, but now it is much easier to
refactor it further with all the tests.

Because almost all lines were touched, this commit introduces some
major code style changes (to my personal preference, e.g. unicode
quotes). I'm not insisting on that style, so if anybody cares enough
it should be possible to submit a PR with unicode stuff autoreplaced.

I wish this commit was split into multiple digestable commits, but it
was a single refactoring effort that I ended up shelving for a few
months anyway, so I'm happy that it goes in at all.
@AlexDaniel AlexDaniel removed their assignment Oct 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDaniel