Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting spaces around / division operator breaks highlights #34

Closed
4 tasks done
zoffixznet opened this issue Dec 29, 2016 · 2 comments
Closed
4 tasks done

Putting spaces around / division operator breaks highlights #34

zoffixznet opened this issue Dec 29, 2016 · 2 comments

Comments

@zoffixznet
Copy link
Contributor

zoffixznet commented Dec 29, 2016

Putting spaces around / division operator breaks highlights

Example Code

# This block is OK, because 1/4 ain't got spaces between the operator and the numbers
isa-ok(Rat.new(1,4), Rat, "Rat.new makes a Rat");
isa-ok(1/4, Rat, "/ makes a Rat");
isa-ok( 1.Int.Rat, Rat, "cast of Int makes a Rat");
isa-ok( 1.Num.Rat, Rat, "cast of Num makes a Rat");

# This one blows up because there are spaces between 1, /, and 4
isa-ok(Rat.new(1,4), Rat, "Rat.new makes a Rat");
isa-ok(1 / 4, Rat, "/ makes a Rat");
isa-ok( 1.Int.Rat, Rat, "cast of Int makes a Rat");
isa-ok( 1.Num.Rat, Rat, "cast of Num makes a Rat");

Picture [optional]

untitled

Leave this in. For internal use.

  • Fixed in Master
  • Fixed in Release
  • Has Tests
  • Passes Tests
@samcv
Copy link
Collaborator

samcv commented Dec 29, 2016

It's actually the second / on that line that is triggering the bare regex thingy. Will need to figure out the best way to fix this.

samcv added a commit that referenced this issue Dec 29, 2016
Make sure we look back one more character to make sure it's not a number
or a letter.
Needs tests.
Fixes issue #34
samcv added a commit that referenced this issue Jan 11, 2017
@samcv
Copy link
Collaborator

samcv commented Jan 11, 2017

Tests have now been added. Closing.

@samcv samcv closed this as completed Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants