Fix for missing parrot phony.exe under cygwin per RT #113992 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pull request puts the fix in the wrong place, unfortunately. First, I think the fix belongs in Parrot, not Rakudo -- see updated comments in RT #113992. Even if it turns out that Rakudo needs to supply a workaround, this is going to be the wrong place to do it. The NQP::Configure module is intended to be shared by NQP, Rakudo, and other languages to be built on top of NQP, so doing repairs of Parrot's tarball hopefully doesn't belong in this (shared) library. I'd be more likely to accept it as a fix in Star's Configure.pl (but I still think it's a Parrot bug that should be fixed in the Parrot tarball). Pm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.