Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make modules-test" doesn't fail when tests fail #21

Closed
coke opened this issue May 14, 2013 · 1 comment
Closed

"make modules-test" doesn't fail when tests fail #21

coke opened this issue May 14, 2013 · 1 comment
Labels
important

Comments

@coke
Copy link
Contributor

coke commented May 14, 2013

The make task should fail if any of the child tests fail. tools/build/modules-test.pl is hardwired to return 0 - it could check the return status of the child "prove" processes and at change the exit code based on that.
@stmuk stmuk mentioned this issue Aug 12, 2017
Closed
@stmuk stmuk added important and removed easy labels Aug 12, 2017
@ronaldxs ronaldxs mentioned this issue Jun 15, 2018
Closed
@Tyil
Copy link
Contributor

Tyil commented Jan 13, 2021

The current iteration uses a Bash script, which should exit with a non-zero exit code if any part of the test subcommand fails. If it does not, this is a bug and you may reopen this issue.

@Tyil Tyil closed this as completed Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coke @Tyil @stmuk