Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-8 Keys Not Lighting Up #3

Closed
ghost opened this issue Jan 28, 2014 · 9 comments
Closed

1-8 Keys Not Lighting Up #3

ghost opened this issue Jan 28, 2014 · 9 comments

Comments

@ghost
Copy link

ghost commented Jan 28, 2014

I have been playing with the step sequencer example code. I increased the grid so I can try to utilize the 1-9 and A-H controls.

I want to control the 1-9 keys along the top, so I can use them to control tick speed and pages. I can use A-H without trouble.

I have not been able to use the pad.Light(0, 8, 4, 0) (and I also tried pad(0, 9, 4, 0)) which should light up 1 but I can do pad.Light(9, 0, 4, 0) which is H.

@rakyll
Copy link
Owner

rakyll commented Jan 28, 2014

The package currently only supports the 64-button grid. I'll add support for the control buttons soon.

@ghost
Copy link
Author

ghost commented Jan 28, 2014

Great, thanks. My plan is to first improve the stepseq example then I will try making other examples.

@ghost
Copy link
Author

ghost commented Feb 17, 2014

I will try adding this feature to the library. I mostly get how to do it but I have some confusion over the hit function. If I get something working Ill submit a pull request.

x = evt.Status % 8                   # why is this modulo 8?
y = 7 - ((evt.Status - x) / 16)    # why is this divided by 16 then -7 and how is x involved?

@rakyll
Copy link
Owner

rakyll commented Feb 18, 2014

I ported them from an existing library in python without much questioning. Novation has a programmer's guide on http://www.novationmusic.com/download/668/ Maybe we should use it as a reference. If you're not actively working on this, I can take a look at this weekend.

@ghost
Copy link
Author

ghost commented Feb 19, 2014

I'm working on it when I have time, thanks for linking to the guide. If you could do it this weekend that would be great but if not I will keep trying.

@ghost
Copy link
Author

ghost commented Feb 25, 2014

Maybe I'm just not understanding it, but does that guide explain how to use the top row of control keys?

I only see it explaining how it addresses the right row of control keys.

@rakyll
Copy link
Owner

rakyll commented Feb 25, 2014

It doesn't explain but I reverse engineered. I also found a crucial bug on the portmidi package, changes are about to be pushed soon.

@rakyll
Copy link
Owner

rakyll commented Feb 25, 2014

d469570 fixes this issue, check out [1] for the new coordinate system.

[1] https://github.com/rakyll/launchpad#light-buttons

@rakyll rakyll closed this as completed Feb 25, 2014
@ghost
Copy link
Author

ghost commented Feb 25, 2014

You are my hero, I can't wait to make awesome instruments using this library. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant