fs: handle Readdir(0) same as Readdir(< 0) #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementations of the File.Readdir method are expected to treat all n <= 0 values the same, returning all the os.FileInfo structures from the directory in a single slice. This is documented at https://godoc.org/net/http#File.Readdir and https://godoc.org/os#File.Readdir. Previously, the n == 0 value was not being handled correctly. This change fixes it by making it work the same as all other negative values of n. Add a test case for it. Also simplify string(out.Bytes()) to just out.String() in a test. Fixes #68. Fixes shurcooL/httpfs#8. Closes shurcooL/httpfs#9.
dmitshur
changed the title
rakyll
approved these changes
Jul 9, 2019
|
Thanks! |
This was referenced Jul 9, 2019
|
Thanks for reviewing! |
ekanna
pushed a commit
to ekanna/statik
that referenced
this pull request
Sep 12, 2019
Implementations of the File.Readdir method are expected to treat all n <= 0 values the same, returning all the os.FileInfo structures from the directory in a single slice. This is documented at https://godoc.org/net/http#File.Readdir and https://godoc.org/os#File.Readdir. Previously, the n == 0 value was not being handled correctly. This change fixes it by making it work the same as all other negative values of n. Add a test case for it. Also simplify string(out.Bytes()) to just out.String() in a test. Fixes rakyll#68. Fixes shurcooL/httpfs#8. Closes shurcooL/httpfs#9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations of the
File.Readdirmethod are expected to treatall n <= 0 values the same, returning all the
os.FileInfostructuresfrom the directory in a single slice. This is documented at
https://godoc.org/net/http#File.Readdir and https://godoc.org/os#File.Readdir.
Previously, the n == 0 value was not being handled correctly.
This change fixes it by making it work the same as all other
negative values of n.
Add a test case for it.
Also simplify
string(out.Bytes())to justout.String()in a test.Fixes #68.
Fixes shurcooL/httpfs#8.
Closes shurcooL/httpfs#9.