Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more instructions if not using a template repo #3

Closed
harsh183 opened this issue Oct 3, 2020 · 2 comments
Closed

Add more instructions if not using a template repo #3

harsh183 opened this issue Oct 3, 2020 · 2 comments

Comments

@harsh183
Copy link

harsh183 commented Oct 3, 2020

I really like this action and I just started using this on one of my small projects.

It took me sometime to figure out how to setup the action just right since reading the bash script I couldn't figure out where some of the arguments were coming from. Perhaps you can include something in the instructions on how to add it to an existing projects so that all the environment variables are just right.

@ralexander-phi
Copy link
Owner

That's really cool! I'm glad to see you got it working.

It looks like you added helpful comments in the workflow for the CS199 EMP site. Do you think I could copy those comments over to the workflow in the template? Is there anything extra you'd recommend? I'm open to pull requests.

@harsh183
Copy link
Author

harsh183 commented Mar 8, 2021

Well basically it took me some time to figure out how to set up MARP_ARGS, and I ended up reading the entire dockerfile and bashscript for it. I think maybe just a table or something in the readme will be good for explaining the options and usage. Nothing too complicated.

Feel free to use any comments as well, you can even provide this as a sample nonstandard version (multiple slide decks on a website).

ralexander-phi added a commit to ralexander-phi/marp-to-pages that referenced this issue Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants