-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metis wrapper broken with metis 5.1.1 and 5.2.1 #133
Comments
Thanks for reporting @traversaro we are aware of this issue but it’s good to have an actual GitHub issue open as this may become a bigger problem going forward. The main issue here is that the enums from the METIS 5 header file are hard-coded in the SPRAL METIS 5 Fortran wrapper, and they change between different versions of METIS 5 (I’m not even sure if they are completely correct for version 5.1.0 atm). Fundamentally this is a flawed design of the METIS 5 Fortran wrapper and the only way that I can see to get around this is to have a C wrapper that imports the METIS 5 C header to query the enums, essentially we can repurpose the COIN wrapper from here: |
Looking deeper into this, the only METIS 5 parameter that the SPRAL METIS 5 Fortran wrapper actually sets is So a quick fix would be to simply use the default C-style (0-based) numbering and just add one to the returned |
Thanks a lot @jfowkes ! |
In https://github.com/ralna/spral/blob/v2023.08.02/src/metis5_wrapper.F90#L77 the values of the elements of the
moption_set
enum are set: KarypisLab/METIS#71 (comment) .However, this values have been changed between METIS 5.1.0 and 5.1.1 , see KarypisLab/METIS#71 (comment) .
I do not think this is a big problem as the official instructions and most users are using METIS 5.1.0, however I want report the problem somewhere to have a reference for people that may encounter problems with METIS >= 5.1.1 .
The text was updated successfully, but these errors were encountered: