Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #133 in a fully backward compatible way by dropping the
METIS_OPTION_NUMBERING=1
option (Fortran-style 1-based indexing) and instead using the METIS 5 default (C-style 0-based indexing) and adding 1 to theperm
andinvp
arrays returned by METIS 5 (the fill-reducing permutation and inverse permutation respectively) as well as subtracting 1 from theptr
androw
input arrays (matrix sparsity pattern in CSR format).Note that there is virtually no performance loss with this change as the
perm
andinvp
arrays returned by METIS 5 are already copied in the wrapper (this is so that their return types are correct). The same is true of the input arraysptr
androw
that encode the matrix sparsity pattern in CSR format which are copied so that the matrix is stored fully (not merely its lower-triangular part) as is expected by METIS 5.