Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions.yaml type: yaml is broken in several ways #10814

Open
viccuad opened this issue Apr 16, 2024 · 1 comment
Open

questions.yaml type: yaml is broken in several ways #10814

viccuad opened this issue Apr 16, 2024 · 1 comment
Labels
area/kubewarden kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this

Comments

@viccuad
Copy link
Member

viccuad commented Apr 16, 2024

Setup

  • Rancher version: 2.8.3
  • Rancher UI Extensions: ui-plugin-operator 103.0.2+up0.2.1
  • Browser type & version: Firefox 115.9.1esr

Describe the bug

Using questions.yaml type: yaml is subtly broken:

  • The render of the formular is incorrect, doesn't show the yaml block until one has clicked on "Edit YAML" and back to "Edit Options".
  • The associated variable is not populated with the default value from values.yaml, when one doesn't set default: foo for that variable.
  • There is no possibility to enforce format of the YAML to specific objects (in this case, Pod's spec.limits, spec.requests, spec.affinity, etc).

This bug blocks exposing affinity/anti-affinity, PodDisruptionBudgets, limits/requests, and others for Kubewarden charts.

To Reproduce

Install kubewarden-controller chart or kubewarden-defaults chart and see its questions, from the following:

Result

Using type: yaml shows correctly, and is populated by the default value from the variable's values.yaml.

Expected Result

Screenshots

Screencast_2024-04-16_15.52.55.webm

Additional context

This bug seems to not be present when configuring Kubewarden policies, via a questions.yaml type: yaml.
(this codebase from what I can see).

Screencast_2024-04-16_16.01.28.webm
@github-actions github-actions bot added [zube]: To Triage QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Apr 16, 2024
@viccuad
Copy link
Member Author

viccuad commented Apr 17, 2024

Note, this seems to be fixed already for Kubewarden UI implementation of questions.yaml (here https://github.com/rancher/kubewarden-ui/blob/main/pkg/kubewarden/components/Questions/index.vue), which is used for the questions of Kubewarden policies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubewarden kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

2 participants