Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aksv2 - for imported clusters, when performing Edits, UI thinks k8s version has been updated #3872

Closed
prabalsharma opened this issue Aug 16, 2021 · 7 comments · Fixed by #11120
Assignees
Labels
kind/bug-qa QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@prabalsharma
Copy link

For imported clusters, when performing Edits from Rancher, UI thinks k8s version has been updated even when thats not the case.

  1. Import AKS cluster
  2. Once Active, click Edit
  3. Go to NPs. You will see the following even when k8s version has not been changed

Screen Shot 2021-08-13 at 2 25 40 PM

This goes away once k8s version of CP is actually upgraded from Rancher.

(This was a Docker install of v2.6-e22c6bb23ee7e65f04e953afb7a449532cb44db0-head)

Feel free to change the milestone to 2.6.x

@prabalsharma prabalsharma added this to the v2.6 milestone Aug 16, 2021
@gaktive gaktive modified the milestones: v2.6, v2.6.x Aug 17, 2021
@gaktive gaktive modified the milestones: v2.6.x, v2.6.1 Aug 17, 2021
@claudioser
Copy link

similar findings when "mistakenly" upgrading from Kubernetes v1.19.11 to 1.21.11. Receive msg that upgrade is not allowed. See screenshot.
image

When trying to edit cluster again and rectifying it to a upgradable version, unable to do so as it thinks it is already upgraded..

image

@gaktive gaktive modified the milestones: v2.6.1, v2.6.2 Sep 1, 2021
@gaktive gaktive modified the milestones: v2.6.2, v2.6.1 Sep 30, 2021
@gaktive
Copy link
Member

gaktive commented Oct 1, 2021

As noted by @vincent99, this is adopted behaviour from kubectl, so the UI is given the same info as you'd see outside of Rancher. Working as designed unless you can show a discrepancy from kubectl.

@gaktive gaktive modified the milestones: v2.6.1, v2.6.2 Oct 1, 2021
@prabalsharma prabalsharma removed their assignment Oct 1, 2021
@vincent99
Copy link
Contributor

@gaktive I don't think your comment is on the right issue? I don't know what the cause of this one is but it has nothing to do with kubectl.

@gaktive
Copy link
Member

gaktive commented Oct 1, 2021

@vincent99 I'll put this back in our pile to look at then. I need to then find out which comment that was meant for...

@nwmac nwmac modified the milestones: v2.6.5, v2.6.x Mar 21, 2022
@mantis-toboggan-md mantis-toboggan-md self-assigned this Aug 16, 2023
@nwmac nwmac added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jan 30, 2024
@yonasberhe23
Copy link
Contributor

seems like there are no e2e/unit tests attached to the fix (I'm guessing it's because we don't have a way to create clusters in a cloud provider - please advise @mantis-toboggan-md) so we'll need to manually test this. moving to To Test

@yonasberhe23 yonasberhe23 self-assigned this Jul 11, 2024
@yonasberhe23
Copy link
Contributor

Tested in:

  • v2.9-3c4ccdc5bc9fde3510089153b5ad58fdbe604880-head
  • master 84975df

No longer seeing the message when k8s version has not been changed on an imported cluster - only appears when version changed

Screen.Recording.2024-07-11.at.11.02.35.AM.mov

@gaktive gaktive modified the milestones: v2.7.x, v2.9.0 Jul 24, 2024
@gaktive
Copy link
Member

gaktive commented Jul 24, 2024

Fixing milestone since this was still in the .x backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-qa QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants