-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Auto Replace" option support for RKE2 machine pools #4449
Comments
See rancher/rancher#35916 (comment) for implementation Support for self healing node pools was added with the pr above. The following fields were added to support this. related: https://cluster-api.sigs.k8s.io/tasks/healthcheck.html
|
Thanks @paynejacob -- does this mean that UI can being work on this as QA tests the backend? |
@gaktive yes qa can test backend and the ui work can start. Let me know if you have any questions about the api. |
@paynejacob It looks like the UI just needs to include the And just to confirm, should we still take the unit from the user in minutes, then convert it to seconds as the Ember UI did? |
@catherineluse it looks like I accidently capitalized it, I will have a pr up soon to make it lowercase. |
@catherineluse fixed |
Setup For Feature Testing **Steps for Reproduction: **
Result Sanity Checks
|
Confirmed with @catherineluse and @gaktive to add |
Detailed Description
For RKE1-provisioned clusters, there is currently an option to specify the threshold on how many minutes a node can be unreachable in a node pool before it's automatically replaced:
For RKE2-provisioned clusters, we want the same functionality to be available, probably by adding a checkbox somewhere on the base pool details section highlighted below:
Context
This is needed for RKE2 provisioning parity with RKE1
Additional Details
Backend support is needed: rancher/rancher#35275
The text was updated successfully, but these errors were encountered: