Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to create git repos in continuous delivery as a restricted admin #4909

Closed
anupama2501 opened this issue Jan 12, 2022 · 6 comments
Closed

Comments

@anupama2501
Copy link

anupama2501 commented Jan 12, 2022

Setup

Rancher version: 2.5.9
Browser type & version: Chrome

Describe the bug
As a restricted admin, I'm not able to create any git repo from the continuous delivery in the explorer. The screen is stuck in loading.

To Reproduce

  1. Create a restricted admin - r1
  2. Login as r1 and from global tools on the ember UI --> continuous delivery --> git repos --> create

Result
Page is stuck in loading and the following console logs were seen:

vue.runtime.esm.js:1888 TypeError: Cannot read properties of null (reading 'filter')
    at f.options (SelectOrCreateAuthSecret.vue:134)
    at _n.get (vue.runtime.esm.js:4479)
    at _n.evaluate (vue.runtime.esm.js:4584)
    at f.options (vue.runtime.esm.js:4836)
    at f.r (SelectOrCreateAuthSecret.vue?8efb:3)
    at f.t._render (vue.runtime.esm.js:3548)
    at f.r (vue.runtime.esm.js:4066)
    at _n.get (vue.runtime.esm.js:4479)
    at _n.run (vue.runtime.esm.js:4554)
    at gn (vue.runtime.esm.js:4310)

Expected Result
Expected the create button to work and the user's able to create a git repo from the UI.

@anupama2501 anupama2501 added this to the v2.5.x milestone Jan 12, 2022
@anupama2501 anupama2501 self-assigned this Jan 12, 2022
@cbron
Copy link
Contributor

cbron commented Jan 13, 2022

This still exists on 2.5.12.

@cbron
Copy link
Contributor

cbron commented Jan 13, 2022

@gaktive this should be release noted for 2.5.12 if it won't be fixed.

@gaktive
Copy link
Member

gaktive commented Jan 13, 2022

@cbron noted. I'll put this as 2.5.12 though as a "won't fix" for QA.

@cbron
Copy link
Contributor

cbron commented Jan 13, 2022

To clarify I meant if it won't be fixed in time. It still needs to be fixed, and we are fairly confident its not a backend issue as it exists in 2.6 as well.

@anupama2501
Copy link
Author

anupama2501 commented Jan 14, 2022

-- Original issue logged in 2.6

Workaround:
If the restricted admin creates a cluster in the cluster manager, the issue [cannot create git repo] is not seen or the git repos can be created via kubectl

@davidnuzik
Copy link

My checks PASSED
Given that I no longer observe this issue in 2.6.3 and v2.6-head my understanding is I can close out this issue. I will do so.

Reproduction Environment:

Rancher version: v2.5.12 and v2.6.3 (I could NOT repro in 2.6.3)
Rancher cluster type: single-node docker install
Docker version: 20.10

Downstream cluster type: n/a
Downstream K8s version: n/a

Reproduction steps:

  1. Create a restricted admin user. Login as the restricted admin.
  2. As the restricted admin user, open Continuous Delivery (in 2.5.12 do this by going to tools -> Continuous Delivery, in 2.6.3 go to Continuous Delivery on the left nav pane).
  3. Now, try to create a gitRepo - You will see a TypeError in the browser dev console and the page does not finish loading due to this.

Additional Info:
In 2.5.12 I see a similar TypeError to the one originally reported:

TypeError: this.allSecrets is null
    options SelectOrCreateAuthSecret.vue:133
    VueJS 3
    r SelectOrCreateAuthSecret.vue:3
    VueJS 13
    e NuxtJS
    d runtime.js:45
    _invoke runtime.js:274
    e runtime.js:97
    Babel 8
    NuxtJS 3
    VueJS 22

In 2.6.3 I do NOT encounter this issue.


Validation Environment:

Rancher version: v2.6.3 and v2.6-head
Rancher cluster type: single-node docker install
Docker version: 20.10

Downstream cluster type: n/a
Downstream K8s version: n/a

Validation steps:

  1. Execute the same steps as those outlined above in the repro section. No TypeError is seen and the Create GitRepo form loads without any issues.

Additional Info:
I tested with v2.6.3 only because the issue mentioned this was a problem in 2.6 so I tried our last release and it didn't have the problem for me. Perhaps an older release like 2.6.0 or 2.6.1 or 2.6.2 did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants