-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet: Add Dashboard view #5048
Comments
@Jono-SUSE-Rancher just added the tag for 2.6.4 so that we could push it out on this release. I have seen that you have been tagging it for QA (if I am not mistaken). Could it be pushed to QA from your side, please? If got this totally wrong, please let me know. Still quite new to the team. Thanks! |
Just to be clear @aalves08 - I actually didn't add this to v2.6.4 or anything. What I might have done is added an associated or related backend Rancher ticket into v2.6.4 to be triaged by team 3 to see if we can try to get it into v2.6.4. |
Ok. So @Jono-SUSE-Rancher shall I keep the v2.6.4 tag that I recently added or remove it? Don't want to mess with the organisation of the work this late if it's not suitable 🙏 |
My advice would be that if this is dependent on the backend ticket getting completed that it's unlikely to be done by v2.6.4. Though we can try. For my own sanity, is the backend ticket we're talking about rancher/rancher#36132? |
This doesn't have any backend tasks associated with it. It's just a FE task to implement this dashboard screen on Fleet Sorry if my communication led to any confusion. |
I am arguably kind of blocked by #5280 but will test without creating more workspaces (this limits my ability to test the dashboard as carefully as I would like to) |
My checks PASSED Reproduction Steps: Not required. Is a new enhancement. Validation Environment: Rancher version: v2.6-head Downstream cluster type: rke2 Validation steps: Rather than posting explicit steps, I think it may make more sense for me to make a bulleted list of areas I focused on / checked during validation of this change. This is because on top of navigating to each page I did a lot of functional, usability, and exploratory testing to ensure that to the best of my ability this change both makes sense and works as expected. *During all testing, monitor the browser dev tools on a separate computer monitor. Ensure there are no network errors and errors in the console.
Additional Info: Nitpick: the whitespace on the left is quite small both on the columns name bar and for each repo - this is probably just the Vue CSS though and could possibly be a UX decision. |
Confirmed with @catherineluse and @gaktive to add |
Add a new dashboard view to Fleet - this should be the top of the nav list and thus the default page that the user comes to.
Design:
Key things to note:
When there are no Git Repositories, we should show a welcome screen instead of the view above:
(We'll refine this over time, but this is good to start). Clicking 'Get Started' will take you to the Create page for Git Repos (we'll improve this at a later stage).
The text was updated successfully, but these errors were encountered: