Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incomprehensible time format #5979

Closed
AbelHugh opened this issue May 18, 2022 · 12 comments
Closed

incomprehensible time format #5979

AbelHugh opened this issue May 18, 2022 · 12 comments
Assignees
Labels
Milestone

Comments

@AbelHugh
Copy link

Rancher Server Setup

  • Rancher version: v2.6.5
  • Installation option (Docker install/Helm Chart): docker

Information about the Cluster

  • Kubernetes version: 1.23.6
  • Cluster Type (Local/Downstream): local

Describe the bug
When I use view logs to view the pod logs, I see the following strange time format,there seems to be something that shouldn't be there
image
Below is my configuration
image
Although I can choose the format of 2022-5-18 here, it will automatically become the format of map[label:...], I don't know if I have not set it correctly

@rak-phillip rak-phillip transferred this issue from rancher/rancher May 18, 2022
@rak-phillip
Copy link
Member

@AbelTaylor thanks for raising the issue 😁

@gaktive I think it's better to classify this one under Dashboard after taking a quick look

@catherineluse
Copy link
Contributor

catherineluse commented May 20, 2022

QA Template

Root cause

I added an input event to the LabeledInput component in this PR #5850 without realizing that other components were listening for that event and expecting certain data to come with it. It caused the input event to be emitted too many times and without the right data being passed into it.

What was fixed, or what changes have occurred

In this PR #5999 I changed the name of the event I added from 'input' to 'selecting' so that it no longer creates unwanted input events.

Areas or cases that should be tested

I tested it by going through the same steps as to reproduce the issue. The steps are in this comment #5989 (comment)

What areas could experience regressions?

The change also affects the secret selector component used for receiver configs in AlertmanagerConfig custom resources. I tested that component locally to confirm that the secret selector still works. But I would say QA doesn't have to test that because the secret selector will be validated again soon because of this issue anyway: #5875

Are the repro steps accurate/minimal?

I believe so

@catherineluse
Copy link
Contributor

The workaround for this issue is:

kubectl delete preferences.management.cattle.io -n [user-id] date-format

@AbelHugh
Copy link
Author

@catherineluse
Can you cancel the time display in view logs? Application logs generally have time, so there is no need to display the time here.

@richard-cox
Copy link
Member

Can you cancel the time display in view logs? Application logs generally have time, so there is no need to display the time here.

@AbelTaylor That's a good request, can you create a separate github issue for it?

@hameno
Copy link

hameno commented May 24, 2022

@catherineluse For me the incorrect value was:

time-format              map[label:12:27:58 value:HH:mm:ss]  

@sowmyav27
Copy link

On 2.6.5 reproduced the issue:
Screen Shot 2022-06-03 at 2 09 07 PM

On 2.6head commit id: 79a3bcb
This is seen fixed
Screen Shot 2022-06-03 at 2 30 00 PM

@kajla
Copy link

kajla commented Aug 29, 2022

Hello,
Still present in Rancher 2.6.6:

time-format              map[label:10:38:01 value:HH:mm:ss]

@kajla
Copy link

kajla commented Aug 29, 2022

Ok, I have got the solution.
I manually edited the time-format value to this:

time-format      HH:mm:ss

It's a 24 hour format.

@kajla
Copy link

kajla commented Aug 29, 2022

date-format also wrong in 2.6.6:

date-format              map[label:2022-08-29 value:YYYY-MM-DD]

@richard-cox
Copy link
Member

@kajla This has been resolved in 2.6.7.

@kajla
Copy link

kajla commented Aug 31, 2022

Thanks, I will update soon.

@zube zube bot removed the [zube]: Done label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants