Imported AKS clusters incorrectly show a K8s upgrade message in the nodepool section, regardless if you have updated the cluster's K8s version

[markusewalker]

Setup

• Rancher version: v2.7-head rancher/rancher@2b2ed44
• Browser type & version: Chrome

Describe the bug

Upon importing a private AKS cluster into Rancher, I wished to upgrade from v1.24.9 to v1.25.5. The upgrade itself was successful, but I noted that when I edited the cluster configuration, I saw this message in the nodepool before I even changed the K8s version:

The above message makes sense when I am editing my cluster and I then proceed to update the K8s version. However, I did not update the K8s version at all, but still see this message. As such, if a user has not selected a new K8s version, we shouldn't be showing any message. If a user does select an upgraded K8s version, then we should show this message.

Additionally, I tested provisioning a hosted AKS cluster from Rancher and doing the same workflow, I DO NOT see this issue. After I updated the K8s version, only then did this warning message appear. That is the behavior I would expect, regardless of the AKS cluster being imported or provisioned directly from Rancher.

To Reproduce

1. As a standard user, navigate to Cluster Management > Import Existing > Azure AKS.
2. Fill out the requested information and import an existing AKS cluster into Rancher
3. Validate that the cluster and nodes come up as Active.
4. Edit the cluster's configuration and scroll down to the node pool section without updating the K8s version for the cluster; you will see this message.

Result
Imported AKS clusters that have not updated the K8s versions yet show aforementioned message in the nodepool section.

Expected Result

Imported AKS clusters should only show the aforementioned message in the nodepool section when a user has updated the cluster's K8s version.

[gaktive]

We can check the behaviour once we complete the migration of AKS provisioning from Ember to Vue.

[yonasberhe23]

seems like there are no e2e/unit tests attached to the fix (I'm guessing it's because we don't have a way to create clusters in a cloud provider - please advise @mantis-toboggan-md) so we'll need to manually test this. moving to To Test

[markusewalker]

Still seeing this issue on v2.8-head rancher/rancher@70e0ba1.

ENVIRONMENT DETAILS

• Rancher install: Docker
• Rancher version: v2.8-head rancher/rancher@70e0ba1

TEST RESULTS

#	Scenario	Result
1	Imported AKS cluster's nodepool section does not show upgraded message on non-upgraded cluster	❌

REPRODUCTION STEPS

1. Setup Rancher v2.8-head.
2. Imported an AKS cluster that I created previously in Azure Dashboard (v1.27.1).
3. Edited the cluster config without updating the K8s version and still see the message:
   

[mantis-toboggan-md]

@markusewalker this should be fixed in 2.9-head, not 2.8-head

[mantis-toboggan-md]

@yonasberhe23 there are unit tests tied to this functionality - the bug is not tied to imported clusters specifically
https://github.com/rancher/dashboard/blob/master/pkg/aks/components/__tests__/AksNodePool.test.ts#L54-L179

[markusewalker]

@mantis-toboggan-md thanks for the clarification! I will proceed to test on v2.9-head and validate/close if all is good.

[markusewalker]

Still seeing this issue on v2.9-head rancher/rancher@ed485b2.

ENVIRONMENT DETAILS

• Rancher install: Docker
• Rancher version: v2.9-head rancher/rancher@ed485b2

TEST RESULTS

#	Scenario	Result
1	Imported AKS cluster's nodepool section does not show upgraded message on non-upgraded cluster	✅

REPRODUCTION STEPS

1. Setup Rancher v2.9-head.
2. Imported an AKS cluster that I created previously in Azure Dashboard (v1.28.10).
3. Edited the cluster config without updating the K8s version and validated that the message is not there.